summaryrefslogtreecommitdiff
path: root/tests/node_compat/test/parallel/test-child-process-exec-std-encoding.js
diff options
context:
space:
mode:
authorNathan Whitaker <17734409+nathanwhit@users.noreply.github.com>2024-07-23 20:12:08 -0700
committerGitHub <noreply@github.com>2024-07-24 03:12:08 +0000
commit29934d558c188fdc3406706da19921ca5a389383 (patch)
treee8fb644f7f90df9ceb32c9bdbba9367aaad833c2 /tests/node_compat/test/parallel/test-child-process-exec-std-encoding.js
parent52ababc4bf948904092cff54c2ab8b91f6b9b443 (diff)
fix(node): Run node compat tests listed in the `ignore` field (and fix the ones that fail) (#24631)
The intent is that those tests will be executed, but our check that the files are up to date won't overwrite the contents of the tests. This is useful when a test needs some manual edits to work. It turns out we weren't actually running them. --- This ended up turning into a couple of small bug fixes to get the tests passing: - We weren't canonicalizing the exec path properly (it sometimes still had `..` or `.` in it) - We weren't accepting strings in `process.exit` There was one failure I couldn't figure out quickly, so I disabled the test for now, and filed a follow up issue: #24694
Diffstat (limited to 'tests/node_compat/test/parallel/test-child-process-exec-std-encoding.js')
-rw-r--r--tests/node_compat/test/parallel/test-child-process-exec-std-encoding.js4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/node_compat/test/parallel/test-child-process-exec-std-encoding.js b/tests/node_compat/test/parallel/test-child-process-exec-std-encoding.js
index 85f3ec2bf..e2f5452b3 100644
--- a/tests/node_compat/test/parallel/test-child-process-exec-std-encoding.js
+++ b/tests/node_compat/test/parallel/test-child-process-exec-std-encoding.js
@@ -7,7 +7,7 @@
// TODO(PolarETech): The process.argv[3] check should be argv[2], and the
// command passed to exec() should not need to include "run", "-A",
-// and "require.ts".
+// and "runner.ts".
'use strict';
const common = require('../common');
@@ -23,7 +23,7 @@ if (process.argv[3] === 'child') {
console.log(stdoutData);
console.error(stderrData);
} else {
- const cmd = `"${process.execPath}" run -A require.ts "${__filename}" child`;
+ const cmd = `"${process.execPath}" run -A runner.ts "${__filename}" child`;
const child = cp.exec(cmd, common.mustSucceed((stdout, stderr) => {
assert.strictEqual(stdout, expectedStdout);
assert.strictEqual(stderr, expectedStderr);