summaryrefslogtreecommitdiff
path: root/tests/napi
diff options
context:
space:
mode:
authorLongYinan <lynweklm@gmail.com>2024-10-17 18:44:51 +0800
committerGitHub <noreply@github.com>2024-10-17 12:44:51 +0200
commit56895858885297537204a16dd463f28b73d25551 (patch)
treed8db9f6e05ea40dc01998800be8ee7fcd6d9d8d1 /tests/napi
parenta61ba3c6995bef58f508a34e537932284692c294 (diff)
fix(cli): set napi object property properly (#26344)
<!-- Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing 1. Give the PR a descriptive title. Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports Examples of bad title: - fix #7123 - update docs - fix bugs 2. Ensure there is a related issue and it is referenced in the PR text. 3. Ensure there are tests that cover the changes. 4. Ensure `cargo test` passes. 5. Ensure `./tools/format.js` passes without changing files. 6. Ensure `./tools/lint.js` passes. 7. Open as a draft PR if your work is still in progress. The CI won't run all steps, but you can add '[ci]' to a commit message to force it to. 8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label. -->
Diffstat (limited to 'tests/napi')
-rw-r--r--tests/napi/object_test.js25
-rw-r--r--tests/napi/src/object.rs29
2 files changed, 53 insertions, 1 deletions
diff --git a/tests/napi/object_test.js b/tests/napi/object_test.js
index 4bc5c3c9c..6226b0138 100644
--- a/tests/napi/object_test.js
+++ b/tests/napi/object_test.js
@@ -1,6 +1,11 @@
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
-import { assert, assertEquals, loadTestLibrary } from "./common.js";
+import {
+ assert,
+ assertEquals,
+ assertThrows,
+ loadTestLibrary,
+} from "./common.js";
const object = loadTestLibrary();
@@ -12,4 +17,22 @@ Deno.test("napi object", function () {
const r1 = object.test_object_get(r);
assert(r === r1);
+
+ const r2 = object.test_object_attr_property(r);
+ assert(r === r2);
+ assertThrows(
+ () => {
+ r2.self = "2";
+ },
+ Error,
+ "Cannot assign to read only property 'self' of object '#<Object>'",
+ );
+
+ assertThrows(
+ () => {
+ r2.method = () => {};
+ },
+ Error,
+ "Cannot assign to read only property 'method' of object '#<Object>'",
+ );
});
diff --git a/tests/napi/src/object.rs b/tests/napi/src/object.rs
index aa34133dc..9876f4dae 100644
--- a/tests/napi/src/object.rs
+++ b/tests/napi/src/object.rs
@@ -40,10 +40,39 @@ extern "C" fn test_object_get(
obj
}
+extern "C" fn test_object_attr_property(
+ env: napi_env,
+ info: napi_callback_info,
+) -> napi_value {
+ let (args, argc, _) = napi_get_callback_info!(env, info, 1);
+ assert_eq!(argc, 1);
+
+ let obj = args[0];
+ let mut property = napi_new_property!(env, "self", test_object_new);
+ property.attributes = PropertyAttributes::enumerable;
+ property.method = None;
+ property.value = obj;
+ let mut method_property = napi_new_property!(env, "method", test_object_new);
+ method_property.attributes = PropertyAttributes::enumerable;
+ let properties = &[property, method_property];
+ assert_napi_ok!(napi_define_properties(
+ env,
+ obj,
+ properties.len(),
+ properties.as_ptr()
+ ));
+ obj
+}
+
pub fn init(env: napi_env, exports: napi_value) {
let properties = &[
napi_new_property!(env, "test_object_new", test_object_new),
napi_new_property!(env, "test_object_get", test_object_get),
+ napi_new_property!(
+ env,
+ "test_object_attr_property",
+ test_object_attr_property
+ ),
];
assert_napi_ok!(napi_define_properties(