summaryrefslogtreecommitdiff
path: root/tests/napi/object_wrap_test.js
diff options
context:
space:
mode:
authorNathan Whitaker <17734409+nathanwhit@users.noreply.github.com>2024-06-13 15:31:42 -0700
committerGitHub <noreply@github.com>2024-06-13 22:31:42 +0000
commit368eb9073bff776b8bb49480b98ca4628ebdc7cd (patch)
tree50e76947b934312d0ebf6a6e95d8e2a48cc10f3b /tests/napi/object_wrap_test.js
parent4ec9250c409fc0734e192d6571b0cad3cbc8a7ee (diff)
fix(napi): Read reference ownership before calling finalizer to avoid crash (#24203)
Fixes #23493. What was happening here was that napi-rs was freeing the napi reference ([here](https://github.com/napi-rs/napi-rs/blob/19e3488efcbc601afa1f11a979372eb6c5ea6130/crates/napi/src/bindgen_runtime/mod.rs#L62)) during its finalize callback (which we call [here](https://github.com/denoland/deno/blob/fb31eaa9ca59f6daaee0210d5cd206185c7041b9/cli/napi/js_native_api.rs#L132)). We then were [reading the `ownership` field](https://github.com/denoland/deno/blob/fb31eaa9ca59f6daaee0210d5cd206185c7041b9/cli/napi/js_native_api.rs#L136) of that freed reference. For some reason on arm macs the freed memory gets zeroed, so the value of `ownership` was `0` when we read it (i.e. it was `ReferenceOwnership::Runtime`). We then freed it again (since we thought we owned it), causing the segfault.
Diffstat (limited to 'tests/napi/object_wrap_test.js')
-rw-r--r--tests/napi/object_wrap_test.js8
1 files changed, 8 insertions, 0 deletions
diff --git a/tests/napi/object_wrap_test.js b/tests/napi/object_wrap_test.js
index de6391fb1..ee6d4af86 100644
--- a/tests/napi/object_wrap_test.js
+++ b/tests/napi/object_wrap_test.js
@@ -40,3 +40,11 @@ Deno.test("napi external arraybuffer", function () {
assertEquals(new Uint8Array(buf), new Uint8Array([1, 2, 3]));
buf = null;
});
+
+Deno.test("napi object wrap userland owned", function () {
+ let obj = new objectWrap.NapiObjectOwned(1);
+ assertEquals(obj.get_value(), 1);
+ obj = null;
+ // force finalize callback to get called
+ globalThis.gc();
+});