diff options
author | Ryan Dahl <ry@tinyclouds.org> | 2021-04-26 13:28:38 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-04-26 13:28:38 -0400 |
commit | f7c298e2972e6a1eb8f9329272ed8e8c9549266c (patch) | |
tree | ed17f90092481db6e5692cff7b3066889541e01e /test_util/src | |
parent | e4e7d957e8cde899d48878c83f2099b0028dfdef (diff) |
Remove denort optimization (#10350)
denort is an optimization to "deno compile" to produce slightly smaller
output. It's a decent idea, but causes a lot of negative side-effects:
- Deno's link time is a source of constant agony both locally and in CI,
denort doubles link time.
- The release process is a long and arduous undertaking with many manual
steps. denort necessitates an additional manual zip + upload from M1
apple computers.
- The "deno compile" interface is complicated with the "--lite" option.
This is confusing for uses ("why wouldn't you want lite?").
The benefits of this feature do not outweigh the negatives. We must find
a different approach to optimizing "deno compile" output.
Diffstat (limited to 'test_util/src')
-rw-r--r-- | test_util/src/lib.rs | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/test_util/src/lib.rs b/test_util/src/lib.rs index abfa86cba..b5719a58b 100644 --- a/test_util/src/lib.rs +++ b/test_util/src/lib.rs @@ -108,15 +108,6 @@ pub fn deno_exe_path() -> PathBuf { p } -pub fn denort_exe_path() -> PathBuf { - // Something like /Users/rld/src/deno/target/debug/deps/denort - let mut p = target_dir().join("denort"); - if cfg!(windows) { - p.set_extension("exe"); - } - p -} - pub fn prebuilt_tool_path(tool: &str) -> PathBuf { let mut exe = tool.to_string(); exe.push_str(if cfg!(windows) { ".exe" } else { "" }); |