diff options
| author | Kyle Kelley <rgbkrk@gmail.com> | 2023-09-17 09:38:52 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-09-17 10:38:52 -0600 |
| commit | 81d6ea8e1174d2b74c2a4806eaf279115cb3068f (patch) | |
| tree | db527e4888be7102dd20c0b3c68663ff0cddc575 /test_util/src | |
| parent | 23bf05cff265c11927b853003dab6c74b4712ec8 (diff) | |
feat(jupyter-kernel): accept nested objects from display calls (#20537)
Closes #20535.
# Screenshots
## JSON
<img width="779" alt="image"
src="https://github.com/denoland/deno/assets/836375/668bb1a6-3f76-4b36-974e-cdc6c93f94c3">
## Vegalite
<img width="558" alt="image"
src="https://github.com/denoland/deno/assets/836375/a5e70908-6b87-42d8-85c3-1323ad52a00f">
# Implementation
Instead of going the route of recursively getting all the objects under
`application/.*json` keys, I went with `JSON.stringify`ing in denospace
then parsing it from rust. One of the key benefits of serializing and
deserializing is that non-JSON-able entries will get stripped
automatically. This also keeps the code pretty simple.
In the future we should _only_ do this for `application/.*json` keys.
cc @mmastrac
Diffstat (limited to 'test_util/src')
0 files changed, 0 insertions, 0 deletions