chore(cli): use NPM_CONFIG_REGISTRY for all tests (#20320)

We never want tests to hit the real npm registry because this causes
test flakes. In addition, we set a sentinal "unset" value for
`NPM_CONFIG_REGISTRY` to ensure that all tests requiring npm go through
the test server.

2 files changed, 21 insertions, 0 deletions

diff --git a/test_util/src/builders.rs b/test_util/src/builders.rs
index 8811efa02..769c054bf 100644
--- a/test_util/src/builders.rs
+++ b/test_util/src/builders.rs
@@ -19,6 +19,7 @@ use crate::env_vars_for_npm_tests_no_sync_download;
 use crate::fs::PathRef;
 use crate::http_server;
 use crate::lsp::LspClientBuilder;
+use crate::npm_registry_unset_url;
 use crate::pty::Pty;
 use crate::strip_ansi_codes;
 use crate::testdata_path;
@@ -266,6 +267,17 @@ impl TestCommandBuilder {
     self
   }
 
+  pub fn envs<S: AsRef<OsStr>>(
+    self,
+    envs: impl IntoIterator<Item = (S, S)>,
+  ) -> Self {
+    let mut this = self;
+    for (k, v) in envs {
+      this = this.env(k, v);
+    }
+    this
+  }
+
   pub fn env_clear(mut self) -> Self {
     self.env_clear = true;
     self
@@ -391,6 +403,10 @@ impl TestCommandBuilder {
       command.env_clear();
     }
     command.env("DENO_DIR", self.context.deno_dir.path());
+    let envs = self.build_envs();
+    if !envs.contains_key("NPM_CONFIG_REGISTRY") {
+      command.env("NPM_CONFIG_REGISTRY", npm_registry_unset_url());
+    }
     command.envs(self.build_envs());
     command.current_dir(cwd);
     command.stdin(Stdio::piped());
diff --git a/test_util/src/lib.rs b/test_util/src/lib.rs
index cf66e3366..fa0cb8a84 100644
--- a/test_util/src/lib.rs
+++ b/test_util/src/lib.rs
@@ -160,6 +160,10 @@ pub fn npm_registry_url() -> String {
   "http://localhost:4545/npm/registry/".to_string()
 }
 
+pub fn npm_registry_unset_url() -> String {
+  "http://NPM_CONFIG_REGISTRY.is.unset".to_string()
+}
+
 pub fn std_path() -> PathRef {
   root_path().join("test_util").join("std")
 }
@@ -2309,6 +2313,7 @@ pub fn deno_cmd_with_deno_dir(deno_dir: &TempDir) -> DenoCmd {
   assert!(exe_path.exists());
   let mut cmd = Command::new(exe_path);
   cmd.env("DENO_DIR", deno_dir.path());
+  cmd.env("NPM_CONFIG_REGISTRY", npm_registry_unset_url());
   DenoCmd {
     _deno_dir: deno_dir.clone(),
     cmd,