summaryrefslogtreecommitdiff
path: root/test_napi/src
diff options
context:
space:
mode:
authorDivy Srivastava <dj.srivastava23@gmail.com>2023-02-10 21:46:56 +0530
committerGitHub <noreply@github.com>2023-02-10 21:46:56 +0530
commit39f131cd762e62e6750b61a5edd6ed0e83995a77 (patch)
tree80331418dddbfd58c222bc55597d763075b07c6e /test_napi/src
parent46817a0e3dc98197cd3e7af0b33efa3533f44ea0 (diff)
fix(cli/napi): correct name handling in napi property descriptor (#17716)
Fixes https://github.com/denoland/deno/issues/17712
Diffstat (limited to 'test_napi/src')
-rw-r--r--test_napi/src/properties.rs41
1 files changed, 20 insertions, 21 deletions
diff --git a/test_napi/src/properties.rs b/test_napi/src/properties.rs
index 1b6c9488b..339699a05 100644
--- a/test_napi/src/properties.rs
+++ b/test_napi/src/properties.rs
@@ -82,27 +82,26 @@ pub fn init(env: napi_env, exports: napi_value) {
attributes: enumerable,
value: number,
},
- // TODO(@littledivy): Fix this.
- // napi_property_descriptor {
- // utf8name: ptr::null(),
- // name: name_value,
- // method: None,
- // getter: None,
- // setter: None,
- // data: ptr::null_mut(),
- // attributes: enumerable,
- // value: number,
- // },
- // napi_property_descriptor {
- // utf8name: ptr::null(),
- // name: name_symbol,
- // method: None,
- // getter: None,
- // setter: None,
- // data: ptr::null_mut(),
- // attributes: enumerable,
- // value: number,
- // },
+ napi_property_descriptor {
+ utf8name: ptr::null(),
+ name: name_value,
+ method: None,
+ getter: None,
+ setter: None,
+ data: ptr::null_mut(),
+ attributes: enumerable,
+ value: number,
+ },
+ napi_property_descriptor {
+ utf8name: ptr::null(),
+ name: name_symbol,
+ method: None,
+ getter: None,
+ setter: None,
+ data: ptr::null_mut(),
+ attributes: enumerable,
+ value: number,
+ },
];
assert_napi_ok!(napi_define_properties(