diff options
author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2020-03-19 00:25:55 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-03-18 19:25:55 -0400 |
commit | 6e2df8c64feb92653077a5494d2c64a9f6fd2f48 (patch) | |
tree | d359310f24622ef38b57538fcdc698f6cadb620d /std/signal/test.ts | |
parent | 070464e2cc617ecbd2c63dc5c4ac0432a77a29fd (diff) |
feat: Deno.test() sanitizes ops and resources (#4399)
This PR brings assertOps and assertResources sanitizers to Deno.test() API.
assertOps checks that test doesn't leak async ops, ie. there are no unresolved
promises originating from Deno APIs. Enabled by default, can be disabled using
Deno.TestDefinition.disableOpSanitizer.
assertResources checks that test doesn't leak resources, ie. all resources used
in test are closed. For example; if a file is opened during a test case it must be
explicitly closed before test case finishes. It's most useful for asynchronous
generators. Enabled by default, can be disabled using
Deno.TestDefinition.disableResourceSanitizer.
We've used those sanitizers in internal runtime tests and it proved very useful in
surfacing incorrect tests which resulted in interference between the tests.
All tests have been sanitized.
Closes #4208
Diffstat (limited to 'std/signal/test.ts')
-rw-r--r-- | std/signal/test.ts | 67 |
1 files changed, 37 insertions, 30 deletions
diff --git a/std/signal/test.ts b/std/signal/test.ts index dfe5bf4cf..d59484e12 100644 --- a/std/signal/test.ts +++ b/std/signal/test.ts @@ -15,40 +15,47 @@ if (Deno.build.os !== "win") { ); }); - test("signal() iterates for multiple signals", async (): Promise<void> => { - // This prevents the program from exiting. - const t = setInterval(() => {}, 1000); + test({ + name: "signal() iterates for multiple signals", + fn: async (): Promise<void> => { + // This prevents the program from exiting. + const t = setInterval(() => {}, 1000); - let c = 0; - const sig = signal( - Deno.Signal.SIGUSR1, - Deno.Signal.SIGUSR2, - Deno.Signal.SIGINT - ); + let c = 0; + const sig = signal( + Deno.Signal.SIGUSR1, + Deno.Signal.SIGUSR2, + Deno.Signal.SIGINT + ); - setTimeout(async () => { - await delay(20); - Deno.kill(Deno.pid, Deno.Signal.SIGINT); - await delay(20); - Deno.kill(Deno.pid, Deno.Signal.SIGUSR2); - await delay(20); - Deno.kill(Deno.pid, Deno.Signal.SIGUSR1); - await delay(20); - Deno.kill(Deno.pid, Deno.Signal.SIGUSR2); - await delay(20); - Deno.kill(Deno.pid, Deno.Signal.SIGUSR1); - await delay(20); - Deno.kill(Deno.pid, Deno.Signal.SIGINT); - await delay(20); - sig.dispose(); - }); + setTimeout(async () => { + await delay(20); + Deno.kill(Deno.pid, Deno.Signal.SIGINT); + await delay(20); + Deno.kill(Deno.pid, Deno.Signal.SIGUSR2); + await delay(20); + Deno.kill(Deno.pid, Deno.Signal.SIGUSR1); + await delay(20); + Deno.kill(Deno.pid, Deno.Signal.SIGUSR2); + await delay(20); + Deno.kill(Deno.pid, Deno.Signal.SIGUSR1); + await delay(20); + Deno.kill(Deno.pid, Deno.Signal.SIGINT); + await delay(20); + sig.dispose(); + }); - for await (const _ of sig) { - c += 1; - } + for await (const _ of sig) { + c += 1; + } - assertEquals(c, 6); + assertEquals(c, 6); - clearTimeout(t); + clearTimeout(t); + // Clear timeout clears interval, but interval promise is not + // yet resolved, delay to next turn of event loop otherwise, + // we'll be leaking resources. + await delay(10); + } }); } |