diff options
author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2021-01-17 00:32:59 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-01-17 00:32:59 +0100 |
commit | b26dcbc69d56b6ac5780520dad47f10460127d3e (patch) | |
tree | 1f0c45b2c39eff83a9fede7a9e6e268a5e04194b /std/node | |
parent | fc45a19801fe32eaf3a82ab8333f433fcfd7ca4e (diff) |
chore: Enforce ban-untagged-todo lint rule (#9135)
Diffstat (limited to 'std/node')
-rw-r--r-- | std/node/_fs/_fs_access.ts | 6 | ||||
-rw-r--r-- | std/node/_fs/_fs_appendFile.ts | 4 | ||||
-rw-r--r-- | std/node/global_test.ts | 2 | ||||
-rw-r--r-- | std/node/module.ts | 6 | ||||
-rw-r--r-- | std/node/timers.ts | 2 | ||||
-rw-r--r-- | std/node/url.ts | 2 |
6 files changed, 11 insertions, 11 deletions
diff --git a/std/node/_fs/_fs_access.ts b/std/node/_fs/_fs_access.ts index cb1903677..3211e1640 100644 --- a/std/node/_fs/_fs_access.ts +++ b/std/node/_fs/_fs_access.ts @@ -4,7 +4,7 @@ import { notImplemented } from "../_utils.ts"; /** Revist once https://github.com/denoland/deno/issues/4017 lands */ -//TODO - 'path' can also be a Buffer. Neither of these polyfills +// TODO(bartlomieju) 'path' can also be a Buffer. Neither of these polyfills //is available yet. See https://github.com/denoland/deno/issues/3403 export function access( _path: string | URL, @@ -14,8 +14,8 @@ export function access( notImplemented("Not yet available"); } -//TODO - 'path' can also be a Buffer. Neither of these polyfills -//is available yet. See https://github.com/denoland/deno/issues/3403 +// TODO(bartlomieju) 'path' can also be a Buffer. Neither of these polyfills +// is available yet. See https://github.com/denoland/deno/issues/3403 // eslint-disable-next-line @typescript-eslint/no-unused-vars export function accessSync(path: string | URL, mode?: number): void { notImplemented("Not yet available"); diff --git a/std/node/_fs/_fs_appendFile.ts b/std/node/_fs/_fs_appendFile.ts index 5a7617632..fab72d0f7 100644 --- a/std/node/_fs/_fs_appendFile.ts +++ b/std/node/_fs/_fs_appendFile.ts @@ -45,7 +45,7 @@ export function appendFile( : undefined; if (mode) { - //TODO rework once https://github.com/denoland/deno/issues/4017 completes + // TODO(bartlomieju) rework once https://github.com/denoland/deno/issues/4017 completes notImplemented("Deno does not yet support setting mode on create"); } Deno.open(pathOrRid as string, getOpenOptions(flag)) @@ -100,7 +100,7 @@ export function appendFileSync( : undefined; if (mode) { - // TODO rework once https://github.com/denoland/deno/issues/4017 completes + // TODO(bartlomieju) rework once https://github.com/denoland/deno/issues/4017 completes notImplemented("Deno does not yet support setting mode on create"); } diff --git a/std/node/global_test.ts b/std/node/global_test.ts index 60c997daf..2ff768f88 100644 --- a/std/node/global_test.ts +++ b/std/node/global_test.ts @@ -7,7 +7,7 @@ import timers from "./timers.ts"; // Definitions for this are quite delicate // This ensures modifications to the global namespace don't break on TypeScript -// TODO +// TODO(bartlomieju): // Deno lint marks globals defined by this module as undefined // probably gonna change in the future diff --git a/std/node/module.ts b/std/node/module.ts index a7052668a..6716b02d9 100644 --- a/std/node/module.ts +++ b/std/node/module.ts @@ -389,7 +389,7 @@ class Module { const module = new Module(filename, parent); if (isMain) { - // TODO: set process info + // TODO(bartlomieju): set process info // process.mainModule = module; module.id = "."; } @@ -1052,7 +1052,7 @@ type RequireWrapper = ( ) => void; function wrapSafe(filename: string, content: string): RequireWrapper { - // TODO: fix this + // TODO(bartlomieju): fix this const wrapper = Module.wrap(content); // deno-lint-ignore no-explicit-any const [f, err] = (Deno as any).core.evalContext(wrapper, filename); @@ -1135,7 +1135,7 @@ function makeRequireFunction(mod: Module): RequireFunction { } resolve.paths = paths; - // TODO: set main + // TODO(bartlomieju): set main // require.main = process.mainModule; // Enable support to add extra extension types. diff --git a/std/node/timers.ts b/std/node/timers.ts index acc2610f7..44c150aaf 100644 --- a/std/node/timers.ts +++ b/std/node/timers.ts @@ -1,5 +1,5 @@ // Copyright 2018-2021 the Deno authors. All rights reserved. MIT license. -// TODO: implement the 'NodeJS.Timeout' and 'NodeJS.Immediate' versions of the timers. +// TODO(bartlomieju): implement the 'NodeJS.Timeout' and 'NodeJS.Immediate' versions of the timers. // https://github.com/DefinitelyTyped/DefinitelyTyped/blob/1163ead296d84e7a3c80d71e7c81ecbd1a130e9a/types/node/v12/globals.d.ts#L1120-L1131 export const setTimeout = window.setTimeout; export const clearTimeout = window.clearTimeout; diff --git a/std/node/url.ts b/std/node/url.ts index a0a3e5f33..9d2fbe757 100644 --- a/std/node/url.ts +++ b/std/node/url.ts @@ -76,7 +76,7 @@ function getPathFromURLWin(url: URL): string { pathname = pathname.replace(forwardSlashRegEx, "\\"); pathname = decodeURIComponent(pathname); if (hostname !== "") { - //TODO add support for punycode encodings + // TODO(bartlomieju): add support for punycode encodings return `\\\\${hostname}${pathname}`; } else { // Otherwise, it's a local path that requires a drive letter |