diff options
author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2020-03-19 00:25:55 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-03-18 19:25:55 -0400 |
commit | 6e2df8c64feb92653077a5494d2c64a9f6fd2f48 (patch) | |
tree | d359310f24622ef38b57538fcdc698f6cadb620d /std/node/_fs | |
parent | 070464e2cc617ecbd2c63dc5c4ac0432a77a29fd (diff) |
feat: Deno.test() sanitizes ops and resources (#4399)
This PR brings assertOps and assertResources sanitizers to Deno.test() API.
assertOps checks that test doesn't leak async ops, ie. there are no unresolved
promises originating from Deno APIs. Enabled by default, can be disabled using
Deno.TestDefinition.disableOpSanitizer.
assertResources checks that test doesn't leak resources, ie. all resources used
in test are closed. For example; if a file is opened during a test case it must be
explicitly closed before test case finishes. It's most useful for asynchronous
generators. Enabled by default, can be disabled using
Deno.TestDefinition.disableResourceSanitizer.
We've used those sanitizers in internal runtime tests and it proved very useful in
surfacing incorrect tests which resulted in interference between the tests.
All tests have been sanitized.
Closes #4208
Diffstat (limited to 'std/node/_fs')
-rw-r--r-- | std/node/_fs/_fs_dir_test.ts | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/std/node/_fs/_fs_dir_test.ts b/std/node/_fs/_fs_dir_test.ts index aefa85854..3b8c5b341 100644 --- a/std/node/_fs/_fs_dir_test.ts +++ b/std/node/_fs/_fs_dir_test.ts @@ -71,8 +71,10 @@ test({ name: "Async read returns one file at a time", async fn() { const testDir: string = Deno.makeTempDirSync(); - Deno.createSync(testDir + "/foo.txt"); - Deno.createSync(testDir + "/bar.txt"); + const f1 = Deno.createSync(testDir + "/foo.txt"); + f1.close(); + const f2 = Deno.createSync(testDir + "/bar.txt"); + f2.close(); try { let secondCallback = false; @@ -108,8 +110,10 @@ test({ name: "Sync read returns one file at a time", fn() { const testDir: string = Deno.makeTempDirSync(); - Deno.createSync(testDir + "/foo.txt"); - Deno.createSync(testDir + "/bar.txt"); + const f1 = Deno.createSync(testDir + "/foo.txt"); + f1.close(); + const f2 = Deno.createSync(testDir + "/bar.txt"); + f2.close(); try { const dir: Dir = new Dir(testDir); @@ -135,8 +139,10 @@ test({ name: "Async iteration over existing directory", async fn() { const testDir: string = Deno.makeTempDirSync(); - Deno.createSync(testDir + "/foo.txt"); - Deno.createSync(testDir + "/bar.txt"); + const f1 = Deno.createSync(testDir + "/foo.txt"); + f1.close(); + const f2 = Deno.createSync(testDir + "/bar.txt"); + f2.close(); try { const dir: Dir = new Dir(testDir); |