diff options
author | Yuki Tanaka <uki00a@gmail.com> | 2020-12-29 23:26:08 +0900 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-12-29 15:26:08 +0100 |
commit | 0e0ffa417bab9e5061847eea547074007d4421f8 (patch) | |
tree | cc5ec147f72a9762506c26f361f9a0534005b41f /std/node/_fs | |
parent | 115de4c81ae6e009c66ac36748fa55f8d3b27b0f (diff) |
chore(std/node/fs): Remove unnecessary try-catch (#8908)
Diffstat (limited to 'std/node/_fs')
-rw-r--r-- | std/node/_fs/_fs_mkdtemp_test.ts | 67 |
1 files changed, 15 insertions, 52 deletions
diff --git a/std/node/_fs/_fs_mkdtemp_test.ts b/std/node/_fs/_fs_mkdtemp_test.ts index c1048acba..b34e95503 100644 --- a/std/node/_fs/_fs_mkdtemp_test.ts +++ b/std/node/_fs/_fs_mkdtemp_test.ts @@ -1,5 +1,9 @@ // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license. -import { assert } from "../../testing/asserts.ts"; +import { + assert, + assertThrows, + assertThrowsAsync, +} from "../../testing/asserts.ts"; import { mkdtemp, mkdtempSync } from "./_fs_mkdtemp.ts"; import { existsSync } from "./_fs_exists.ts"; import { env } from "../process.ts"; @@ -16,56 +20,32 @@ const mkdtempP = promisify(mkdtemp); Deno.test({ name: "[node/fs] mkdtemp", fn: async () => { - try { - const directory = await mkdtempP(prefix); - assert(existsSync(directory)); - Deno.removeSync(directory); - } catch (error) { - assert(false); - } + const directory = await mkdtempP(prefix); + assert(existsSync(directory)); + Deno.removeSync(directory); }, }); Deno.test({ name: "[node/fs] mkdtemp (does not exists)", fn: async () => { - try { - const directory = await mkdtempP(doesNotExists); - - // should have thrown already... - assert(!existsSync(directory)); - Deno.removeSync(directory); - } catch (error) { - assert(true); - } + await assertThrowsAsync(() => mkdtempP(doesNotExists)); }, }); Deno.test({ name: "[node/fs] mkdtemp (with options)", fn: async () => { - try { - const directory = await mkdtempP(prefix, options); - assert(existsSync(directory)); - Deno.removeSync(directory); - } catch (error) { - assert(false); - } + const directory = await mkdtempP(prefix, options); + assert(existsSync(directory)); + Deno.removeSync(directory); }, }); Deno.test({ name: "[node/fs] mkdtemp (with bad options)", fn: async () => { - try { - const directory = await mkdtempP(prefix, badOptions); - - // should have thrown already... - assert(!existsSync(directory)); - Deno.removeSync(directory); - } catch (error) { - assert(true); - } + await assertThrowsAsync(() => mkdtempP(prefix, badOptions)); }, }); @@ -82,16 +62,7 @@ Deno.test({ Deno.test({ name: "[node/fs] mkdtempSync (does not exists)", fn: () => { - try { - const directory = mkdtempSync(doesNotExists); - // should have thrown already... - - const dirExists = existsSync(directory); - Deno.removeSync(directory); - assert(!dirExists); - } catch (error) { - assert(true); - } + assertThrows(() => mkdtempSync(doesNotExists)); }, }); @@ -108,14 +79,6 @@ Deno.test({ Deno.test({ name: "[node/fs] mkdtempSync (with bad options)", fn: () => { - try { - const directory = mkdtempSync(prefix, badOptions); - // should have thrown already... - - Deno.removeSync(directory); - assert(false); - } catch (error) { - assert(true); - } + assertThrows(() => mkdtempSync(prefix, badOptions)); }, }); |