fix(std/node): Stop callbacks being called twice when callback throws error (#8867)

1 files changed, 15 insertions, 2 deletions

diff --git a/std/node/_fs/_fs_rename_test.ts b/std/node/_fs/_fs_rename_test.ts
index d0ba89644..e35e5282e 100644
--- a/std/node/_fs/_fs_rename_test.ts
+++ b/std/node/_fs/_fs_rename_test.ts
@@ -1,4 +1,5 @@
 import { assertEquals, fail } from "../../testing/asserts.ts";
+import { assertCallbackErrorUncaught } from "../_utils.ts";
 import { rename, renameSync } from "./_fs_rename.ts";
 import { existsSync } from "../../fs/mod.ts";
 import { join, parse } from "../../path/mod.ts";
@@ -17,8 +18,7 @@ Deno.test({
       .then(() => {
         assertEquals(existsSync(newPath), true);
         assertEquals(existsSync(file), false);
-      })
-      .catch(() => fail())
+      }, () => fail())
       .finally(() => {
         if (existsSync(file)) Deno.removeSync(file);
         if (existsSync(newPath)) Deno.removeSync(newPath);
@@ -36,3 +36,16 @@ Deno.test({
     assertEquals(existsSync(file), false);
   },
 });
+
+Deno.test("[std/node/fs] rename callback isn't called twice if error is thrown", async () => {
+  const tempFile = await Deno.makeTempFile();
+  const importUrl = new URL("./_fs_rename.ts", import.meta.url);
+  await assertCallbackErrorUncaught({
+    prelude: `import { rename } from ${JSON.stringify(importUrl)}`,
+    invocation: `rename(${JSON.stringify(tempFile)}, 
+                        ${JSON.stringify(`${tempFile}.newname`)}, `,
+    async cleanup() {
+      await Deno.remove(`${tempFile}.newname`);
+    },
+  });
+});