fix(std/node): Stop callbacks being called twice when callback throws error (#8867)

1 files changed, 13 insertions, 0 deletions

diff --git a/std/node/_fs/_fs_readFile_test.ts b/std/node/_fs/_fs_readFile_test.ts
index 50fe569ff..7af32c8a1 100644
--- a/std/node/_fs/_fs_readFile_test.ts
+++ b/std/node/_fs/_fs_readFile_test.ts
@@ -1,4 +1,5 @@
 // Copyright 2018-2021 the Deno authors. All rights reserved. MIT license.
+import { assertCallbackErrorUncaught } from "../_utils.ts";
 import { readFile, readFileSync } from "./_fs_readFile.ts";
 import * as path from "../../path/mod.ts";
 import { assert, assertEquals } from "../../testing/asserts.ts";
@@ -103,3 +104,15 @@ Deno.test("readFileEncodeAsString", function () {
   assertEquals(typeof data, "string");
   assertEquals(data as string, "hello world");
 });
+
+Deno.test("[std/node/fs] readFile callback isn't called twice if error is thrown", async () => {
+  const tempFile = await Deno.makeTempFile();
+  const importUrl = new URL("./_fs_readFile.ts", import.meta.url);
+  await assertCallbackErrorUncaught({
+    prelude: `import { readFile } from ${JSON.stringify(importUrl)}`,
+    invocation: `readFile(${JSON.stringify(tempFile)}, `,
+    async cleanup() {
+      await Deno.remove(tempFile);
+    },
+  });
+});