fix(std/node): Stop callbacks being called twice when callback throws error (#8867)

1 files changed, 15 insertions, 0 deletions

diff --git a/std/node/_fs/_fs_mkdir_test.ts b/std/node/_fs/_fs_mkdir_test.ts
index e3d68ea9c..c13d065fe 100644
--- a/std/node/_fs/_fs_mkdir_test.ts
+++ b/std/node/_fs/_fs_mkdir_test.ts
@@ -1,5 +1,7 @@
 // Copyright 2018-2021 the Deno authors. All rights reserved. MIT license.
+import * as path from "../../path/mod.ts";
 import { assert } from "../../testing/asserts.ts";
+import { assertCallbackErrorUncaught } from "../_utils.ts";
 import { mkdir, mkdirSync } from "./_fs_mkdir.ts";
 import { existsSync } from "./_fs_exists.ts";
 
@@ -27,3 +29,16 @@ Deno.test({
     Deno.removeSync(tmpDir);
   },
 });
+
+Deno.test("[std/node/fs] mkdir callback isn't called twice if error is thrown", async () => {
+  const tempDir = await Deno.makeTempDir();
+  const subdir = path.join(tempDir, "subdir");
+  const importUrl = new URL("./_fs_mkdir.ts", import.meta.url);
+  await assertCallbackErrorUncaught({
+    prelude: `import { mkdir } from ${JSON.stringify(importUrl)}`,
+    invocation: `mkdir(${JSON.stringify(subdir)}, `,
+    async cleanup() {
+      await Deno.remove(tempDir, { recursive: true });
+    },
+  });
+});