fix(std/node): Stop callbacks being called twice when callback throws error (#8867)

1 files changed, 6 insertions, 14 deletions

diff --git a/std/node/_fs/_fs_dir.ts b/std/node/_fs/_fs_dir.ts
index b2353146b..4f7beec31 100644
--- a/std/node/_fs/_fs_dir.ts
+++ b/std/node/_fs/_fs_dir.ts
@@ -32,10 +32,9 @@ export default class Dir {
           if (callback) {
             callback(null, value ? value : null);
           }
-        })
-        .catch((err) => {
+        }, (err) => {
           if (callback) {
-            callback(err, null);
+            callback(err);
           }
           reject(err);
         });
@@ -59,18 +58,11 @@ export default class Dir {
    */
   // deno-lint-ignore no-explicit-any
   close(callback?: (...args: any[]) => void): Promise<void> {
-    return new Promise((resolve, reject) => {
-      try {
-        if (callback) {
-          callback(null);
-        }
-        resolve();
-      } catch (err) {
-        if (callback) {
-          callback(err);
-        }
-        reject(err);
+    return new Promise((resolve) => {
+      if (callback) {
+        callback(null);
       }
+      resolve();
     });
   }