fix(std/node): Stop callbacks being called twice when callback throws error (#8867)

1 files changed, 18 insertions, 2 deletions

diff --git a/std/node/_fs/_fs_close_test.ts b/std/node/_fs/_fs_close_test.ts
index 047f6d977..df5a93240 100644
--- a/std/node/_fs/_fs_close_test.ts
+++ b/std/node/_fs/_fs_close_test.ts
@@ -1,5 +1,6 @@
 // Copyright 2018-2021 the Deno authors. All rights reserved. MIT license.
 import { assert, assertThrows, fail } from "../../testing/asserts.ts";
+import { assertCallbackErrorUncaught } from "../_utils.ts";
 import { close, closeSync } from "./_fs_close.ts";
 
 Deno.test({
@@ -17,8 +18,7 @@ Deno.test({
     })
       .then(() => {
         assert(!Deno.resources()[file.rid]);
-      })
-      .catch(() => {
+      }, () => {
         fail("No error expected");
       })
       .finally(async () => {
@@ -78,3 +78,19 @@ Deno.test({
     assertThrows(() => closeSync(-1));
   },
 });
+
+Deno.test("[std/node/fs] close callback isn't called twice if error is thrown", async () => {
+  const tempFile = await Deno.makeTempFile();
+  const importUrl = new URL("./_fs_close.ts", import.meta.url);
+  await assertCallbackErrorUncaught({
+    prelude: `
+    import { close } from ${JSON.stringify(importUrl)};
+
+    const file = await Deno.open(${JSON.stringify(tempFile)});
+    `,
+    invocation: "close(file.rid, ",
+    async cleanup() {
+      await Deno.remove(tempFile);
+    },
+  });
+});