fix(std/node): Stop callbacks being called twice when callback throws error (#8867)

1 files changed, 18 insertions, 2 deletions

diff --git a/std/node/_fs/_fs_chmod_test.ts b/std/node/_fs/_fs_chmod_test.ts
index 5f946794e..4d8647782 100644
--- a/std/node/_fs/_fs_chmod_test.ts
+++ b/std/node/_fs/_fs_chmod_test.ts
@@ -1,5 +1,6 @@
 // Copyright 2018-2021 the Deno authors. All rights reserved. MIT license.
 import { assert, fail } from "../../testing/asserts.ts";
+import { assertCallbackErrorUncaught } from "../_utils.ts";
 import { chmod, chmodSync } from "./_fs_chmod.ts";
 
 Deno.test({
@@ -18,8 +19,7 @@ Deno.test({
         const newFileMode: number | null = Deno.lstatSync(tempFile).mode;
         assert(newFileMode && originalFileMode);
         assert(newFileMode === 33279 && newFileMode > originalFileMode);
-      })
-      .catch(() => {
+      }, () => {
         fail();
       })
       .finally(() => {
@@ -42,3 +42,19 @@ Deno.test({
     Deno.removeSync(tempFile);
   },
 });
+
+Deno.test({
+  name: "[std/node/fs] chmod callback isn't called twice if error is thrown",
+  ignore: Deno.build.os === "windows",
+  async fn() {
+    const tempFile = await Deno.makeTempFile();
+    const importUrl = new URL("./_fs_chmod.ts", import.meta.url);
+    await assertCallbackErrorUncaught({
+      prelude: `import { chmod } from ${JSON.stringify(importUrl)}`,
+      invocation: `chmod(${JSON.stringify(tempFile)}, 0o777, `,
+      async cleanup() {
+        await Deno.remove(tempFile);
+      },
+    });
+  },
+});