feat: Deno.test() sanitizes ops and resources (#4399)

This PR brings assertOps and assertResources sanitizers to Deno.test() API.

assertOps checks that test doesn't leak async ops, ie. there are no unresolved
promises originating from Deno APIs. Enabled by default, can be disabled using 
Deno.TestDefinition.disableOpSanitizer.

assertResources checks that test doesn't leak resources, ie. all resources used
in test are closed. For example; if a file is opened during a test case it must be
explicitly closed before test case finishes. It's most useful for asynchronous
generators. Enabled by default, can be disabled using 
Deno.TestDefinition.disableResourceSanitizer.

We've used those sanitizers in internal runtime tests and it proved very useful in
surfacing incorrect tests which resulted in interference between the tests.

All tests have been sanitized.

Closes #4208

1 files changed, 33 insertions, 33 deletions

diff --git a/std/examples/tests/curl_test.ts b/std/examples/tests/curl_test.ts
index 71a0fe67f..593e5b8f7 100644
--- a/std/examples/tests/curl_test.ts
+++ b/std/examples/tests/curl_test.ts
@@ -1,41 +1,41 @@
 // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
-import { Server, serve } from "../../http/server.ts";
+import { serve } from "../../http/server.ts";
 import { assertStrictEq } from "../../testing/asserts.ts";
 
-let server: Server | undefined;
+Deno.test({
+  name: "[examples/curl] send a request to a specified url",
+  // FIXME(bartlomieju): this test is leaking both resources and ops,
+  // and causes interference with other tests
+  skip: true,
+  fn: async () => {
+    const server = serve({ port: 8081 });
+    (async (): Promise<void> => {
+      for await (const req of server) {
+        req.respond({ body: "Hello world" });
+      }
+    })();
 
-async function startTestServer(): Promise<void> {
-  server = await serve({ port: 8080 });
-  (async (): Promise<void> => {
-    for await (const req of server) {
-      req.respond({ body: "Hello world" });
-    }
-  })();
-}
-
-Deno.test("[examples/curl] beforeAll", async () => {
-  await startTestServer();
-});
-
-Deno.test("[examples/curl] send a request to a specified url", async () => {
-  const decoder = new TextDecoder();
-  const process = Deno.run({
-    args: [Deno.execPath(), "--allow-net", "curl.ts", "http://localhost:8080"],
-    cwd: "examples",
-    stdout: "piped"
-  });
+    const decoder = new TextDecoder();
+    const process = Deno.run({
+      args: [
+        Deno.execPath(),
+        "--allow-net",
+        "curl.ts",
+        "http://localhost:8081"
+      ],
+      cwd: "examples",
+      stdout: "piped"
+    });
 
-  try {
-    const output = await Deno.readAll(process.stdout!);
-    const actual = decoder.decode(output).trim();
-    const expected = "Hello world";
+    try {
+      const output = await process.output();
+      const actual = decoder.decode(output).trim();
+      const expected = "Hello world";
 
-    assertStrictEq(actual, expected);
-  } finally {
-    process.close();
+      assertStrictEq(actual, expected);
+    } finally {
+      process.close();
+      server.close();
+    }
   }
 });
-
-Deno.test("[examples/curl] afterAll", () => {
-  server?.close();
-});