diff options
author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2020-03-19 00:25:55 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-03-18 19:25:55 -0400 |
commit | 6e2df8c64feb92653077a5494d2c64a9f6fd2f48 (patch) | |
tree | d359310f24622ef38b57538fcdc698f6cadb620d /std/examples/tests/catj_test.ts | |
parent | 070464e2cc617ecbd2c63dc5c4ac0432a77a29fd (diff) |
feat: Deno.test() sanitizes ops and resources (#4399)
This PR brings assertOps and assertResources sanitizers to Deno.test() API.
assertOps checks that test doesn't leak async ops, ie. there are no unresolved
promises originating from Deno APIs. Enabled by default, can be disabled using
Deno.TestDefinition.disableOpSanitizer.
assertResources checks that test doesn't leak resources, ie. all resources used
in test are closed. For example; if a file is opened during a test case it must be
explicitly closed before test case finishes. It's most useful for asynchronous
generators. Enabled by default, can be disabled using
Deno.TestDefinition.disableResourceSanitizer.
We've used those sanitizers in internal runtime tests and it proved very useful in
surfacing incorrect tests which resulted in interference between the tests.
All tests have been sanitized.
Closes #4208
Diffstat (limited to 'std/examples/tests/catj_test.ts')
-rw-r--r-- | std/examples/tests/catj_test.ts | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/std/examples/tests/catj_test.ts b/std/examples/tests/catj_test.ts index 9267f532b..2d667dacc 100644 --- a/std/examples/tests/catj_test.ts +++ b/std/examples/tests/catj_test.ts @@ -5,7 +5,7 @@ Deno.test("[examples/catj] print an array", async () => { const decoder = new TextDecoder(); const process = catj("testdata/catj/array.json"); try { - const output = await Deno.readAll(process.stdout!); + const output = await process.output(); const actual = decoder.decode(output).trim(); const expected = [ '.[0] = "string"', @@ -17,6 +17,7 @@ Deno.test("[examples/catj] print an array", async () => { assertStrictEq(actual, expected); } finally { + process.stdin!.close(); process.close(); } }); @@ -25,7 +26,7 @@ Deno.test("[examples/catj] print an object", async () => { const decoder = new TextDecoder(); const process = catj("testdata/catj/object.json"); try { - const output = await Deno.readAll(process.stdout!); + const output = await process.output(); const actual = decoder.decode(output).trim(); const expected = [ '.string = "foobar"', @@ -35,6 +36,7 @@ Deno.test("[examples/catj] print an object", async () => { assertStrictEq(actual, expected); } finally { + process.stdin!.close(); process.close(); } }); @@ -46,12 +48,13 @@ Deno.test("[examples/catj] print multiple files", async () => { "testdata/catj/simple-array.json" ); try { - const output = await Deno.readAll(process.stdout!); + const output = await process.output(); const actual = decoder.decode(output).trim(); const expected = ['.message = "hello"', ".[0] = 1", ".[1] = 2"].join("\n"); assertStrictEq(actual, expected); } finally { + process.stdin!.close(); process.close(); } }); @@ -63,7 +66,7 @@ Deno.test("[examples/catj] read from stdin", async () => { try { await process.stdin!.write(new TextEncoder().encode(input)); process.stdin!.close(); - const output = await Deno.readAll(process.stdout!); + const output = await process.output(); const actual = decoder.decode(output).trim(); assertStrictEq(actual, '.foo = "bar"'); |