diff options
author | Ryan Dahl <ry@tinyclouds.org> | 2019-01-09 12:59:46 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-01-09 12:59:46 -0500 |
commit | 0ceb554343ff3d311a19f027b7aa8f0806bbb162 (patch) | |
tree | 24603f165b7da831c2b68ad9472e26fabf72134c /src/workers.rs | |
parent | 3afdae165d3bc9acb5e5a4749334d2673f2566af (diff) |
Native ES modules (#1460)
* Native ES modules
This is a major refactor of internal compiler.
Before: JS and TS both were sent through the typescript compiler where
their imports were parsed and handled. Both compiled to AMD JS and
finally sent to V8
Now: JS is sent directly into V8. TS is sent through the typescript
compiler, but tsc generates ES modules now instead of AMD. This
generated JS is then dumped into V8.
This should much faster for pure JS code. It may improve TS compilation
speed.
In the future this allows us to separate TS out of the runtime heap and
into its own dedicated snapshot. This will result in a smaller runtime
heap, and thus should be faster.
Some tests were unfortunately disabled to ease landing this patch:
1. compiler_tests.ts which I intend to bring back in later commits.
2. Some text_encoding_test.ts tests which made the file invalid utf8.
See PR for a discussion.
Also worth noting that this is necessary to support WASM
Diffstat (limited to 'src/workers.rs')
-rw-r--r-- | src/workers.rs | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/src/workers.rs b/src/workers.rs index 319f4018d..e67d80489 100644 --- a/src/workers.rs +++ b/src/workers.rs @@ -1,7 +1,4 @@ // Copyright 2018 the Deno authors. All rights reserved. MIT license. - -#![allow(dead_code)] - use isolate::Buf; use isolate::Isolate; use isolate::IsolateState; @@ -53,7 +50,10 @@ impl Worker { } } -fn spawn(state: Arc<IsolateState>, js_source: String) -> resources::Resource { +pub fn spawn( + state: Arc<IsolateState>, + js_source: String, +) -> resources::Resource { // TODO This function should return a Future, so that the caller can retrieve // the JSError if one is thrown. Currently it just prints to stderr and calls // exit(1). @@ -64,11 +64,12 @@ fn spawn(state: Arc<IsolateState>, js_source: String) -> resources::Resource { .spawn(move || { let (worker, external_channels) = Worker::new(&state); - let mut resource = resources::add_worker(external_channels); + let resource = resources::add_worker(external_channels); p.send(resource.clone()).unwrap(); tokio_util::init(|| { (|| -> Result<(), JSError> { + worker.execute("denoMain()")?; worker.execute("workerMain()")?; worker.execute(&js_source)?; worker.event_loop()?; @@ -142,7 +143,8 @@ mod tests { // TODO Need a way to get a future for when a resource closes. // For now, just sleep for a bit. - thread::sleep(std::time::Duration::from_millis(100)); + // resource.close(); + thread::sleep(std::time::Duration::from_millis(1000)); assert_eq!(resources::get_type(resource.rid), None); } } |