diff options
| author | Divy Srivastava <dj.srivastava23@gmail.com> | 2024-01-05 18:28:33 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-05 18:28:33 +0530 |
| commit | df062d2c788fd76546d59c67452d8d0fe569c533 (patch) | |
| tree | b82a837378469c3eb1456aeea40354601b040793 /runtime/snapshot.rs | |
| parent | bac51f66aa89dd9b79a3c4e844423c3a3399ea13 (diff) | |
fix(ext/node): add fs.cp, fs.cpSync, promises.cp (#21745)
Fixes https://github.com/denoland/deno/issues/20803
Fixes https://github.com/denoland/deno/issues/21723
Performance: copying a 48GiB rust `target` folder (recursive)
| Platform | `deno` | `node v21.5` | Improvement |
| -------- | ------- | ------- | ------- |
| macOS (APFS) | 3.1secs | 127.99 secs | **42x** |
| Windows | 18.3secs | 67.2secs | **3.8x** |
Copying files with varying sizes:
Diffstat (limited to 'runtime/snapshot.rs')
| -rw-r--r-- | runtime/snapshot.rs | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/runtime/snapshot.rs b/runtime/snapshot.rs index 978f3d70e..a50f0773a 100644 --- a/runtime/snapshot.rs +++ b/runtime/snapshot.rs @@ -84,6 +84,13 @@ impl deno_node::NodePermissions for Permissions { ) -> Result<(), deno_core::error::AnyError> { unreachable!("snapshotting!") } + fn check_write_with_api_name( + &self, + _p: &Path, + _api_name: Option<&str>, + ) -> Result<(), deno_core::error::AnyError> { + unreachable!("snapshotting!") + } fn check_sys( &self, _kind: &str, |