summaryrefslogtreecommitdiff
path: root/runtime/snapshot.rs
diff options
context:
space:
mode:
authorDivy Srivastava <dj.srivastava23@gmail.com>2024-03-12 10:42:26 -0700
committerGitHub <noreply@github.com>2024-03-12 10:42:26 -0700
commitde28e6fc09f30c05a38c257137ee8d15150cc1a6 (patch)
tree037be759d6d754a5d88146bfe07c8b7033882bda /runtime/snapshot.rs
parent4a88695563ced73e18a97be06f9f0864be683eff (diff)
refactor: add `deno_permissions` crate (#22236)
Issue https://github.com/denoland/deno/issues/22222 ![image](https://github.com/denoland/deno/assets/34997667/2af8474b-b919-4519-98ce-9d29bc7829f2) This PR moves `runtime/permissions` code to a upstream crate called `deno_permissions`. The `deno_permissions::PermissionsContainer` is put into the OpState and can be used instead of the current trait-based permissions system. For this PR, I've migrated `deno_fetch` to the new crate but kept the rest of the trait-based system as a wrapper of `deno_permissions` crate. Doing the migration all at once is error prone and hard to review. Comparing incremental compile times for `ext/fetch` on Mac M1: | profile | `cargo build --bin deno` | `cargo plonk build --bin deno` | | --------- | ------------- | ------------------- | | `debug` | 20 s | 0.8s | | `release` | 4 mins 12 s | 1.4s |
Diffstat (limited to 'runtime/snapshot.rs')
-rw-r--r--runtime/snapshot.rs20
1 files changed, 10 insertions, 10 deletions
diff --git a/runtime/snapshot.rs b/runtime/snapshot.rs
index edfef39c2..54652e1f1 100644
--- a/runtime/snapshot.rs
+++ b/runtime/snapshot.rs
@@ -19,7 +19,7 @@ use std::sync::Arc;
#[derive(Clone)]
struct Permissions;
-impl deno_fetch::FetchPermissions for Permissions {
+impl deno_websocket::WebSocketPermissions for Permissions {
fn check_net_url(
&mut self,
_url: &deno_core::url::Url,
@@ -27,17 +27,15 @@ impl deno_fetch::FetchPermissions for Permissions {
) -> Result<(), deno_core::error::AnyError> {
unreachable!("snapshotting!")
}
+}
- fn check_read(
- &mut self,
- _p: &Path,
- _api_name: &str,
- ) -> Result<(), deno_core::error::AnyError> {
+impl deno_web::TimersPermission for Permissions {
+ fn allow_hrtime(&mut self) -> bool {
unreachable!("snapshotting!")
}
}
-impl deno_websocket::WebSocketPermissions for Permissions {
+impl deno_fetch::FetchPermissions for Permissions {
fn check_net_url(
&mut self,
_url: &deno_core::url::Url,
@@ -45,10 +43,12 @@ impl deno_websocket::WebSocketPermissions for Permissions {
) -> Result<(), deno_core::error::AnyError> {
unreachable!("snapshotting!")
}
-}
-impl deno_web::TimersPermission for Permissions {
- fn allow_hrtime(&mut self) -> bool {
+ fn check_read(
+ &mut self,
+ _p: &Path,
+ _api_name: &str,
+ ) -> Result<(), deno_core::error::AnyError> {
unreachable!("snapshotting!")
}
}