diff options
| author | Bartek Iwańczuk <biwanczuk@gmail.com> | 2023-06-22 23:37:56 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-22 23:37:56 +0200 |
| commit | dda0f1c343bfb3196ce6a7c7e8c2acccfd5c2e5b (patch) | |
| tree | 10fc273a620949ccf63826363499f8f39056896d /runtime/ops | |
| parent | b319fa7f4965af3d3d576ea528248a31c96a4053 (diff) | |
refactor(serde_v8): split ZeroCopyBuf into JsBuffer and ToJsBuffer (#19566)
`ZeroCopyBuf` was convenient to use, but sometimes it did hide details
that some copies were necessary in certain cases. Also it made it way to easy
for the caller to pass around and convert into different values. This commit
splits `ZeroCopyBuf` into `JsBuffer` (an array buffer coming from V8) and
`ToJsBuffer` (a Rust buffer that will be converted into a V8 array buffer).
As a result some magical conversions were removed (they were never used)
limiting the API surface and preparing for changes in #19534.
Diffstat (limited to 'runtime/ops')
| -rw-r--r-- | runtime/ops/http.rs | 4 | ||||
| -rw-r--r-- | runtime/ops/process.rs | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/runtime/ops/http.rs b/runtime/ops/http.rs index eb2711257..35e181d3e 100644 --- a/runtime/ops/http.rs +++ b/runtime/ops/http.rs @@ -11,7 +11,7 @@ use deno_core::op; use deno_core::OpState; use deno_core::RcRef; use deno_core::ResourceId; -use deno_core::ZeroCopyBuf; +use deno_core::ToJsBuffer; use deno_http::http_create_conn_resource; use deno_http::HttpRequestReader; use deno_http::HttpStreamResource; @@ -93,7 +93,7 @@ fn op_http_start( pub struct HttpUpgradeResult { conn_rid: ResourceId, conn_type: &'static str, - read_buf: ZeroCopyBuf, + read_buf: ToJsBuffer, } #[op] diff --git a/runtime/ops/process.rs b/runtime/ops/process.rs index 44429fdab..14d773af0 100644 --- a/runtime/ops/process.rs +++ b/runtime/ops/process.rs @@ -12,7 +12,7 @@ use deno_core::OpState; use deno_core::RcRef; use deno_core::Resource; use deno_core::ResourceId; -use deno_core::ZeroCopyBuf; +use deno_core::ToJsBuffer; use deno_io::fs::FileResource; use deno_io::ChildStderrResource; use deno_io::ChildStdinResource; @@ -198,8 +198,8 @@ impl TryFrom<ExitStatus> for ChildStatus { #[serde(rename_all = "camelCase")] pub struct SpawnOutput { status: ChildStatus, - stdout: Option<ZeroCopyBuf>, - stderr: Option<ZeroCopyBuf>, + stdout: Option<ToJsBuffer>, + stderr: Option<ToJsBuffer>, } fn create_command( |