feat: return a signal string instead number on ChildStatus (#14643)

1 files changed, 24 insertions, 17 deletions

diff --git a/runtime/ops/spawn.rs b/runtime/ops/spawn.rs
index 0f329e16e..7e7e2d05e 100644
--- a/runtime/ops/spawn.rs
+++ b/runtime/ops/spawn.rs
@@ -73,22 +73,29 @@ pub struct ChildStdio {
 pub struct ChildStatus {
   success: bool,
   code: i32,
-  signal: Option<i32>,
+  signal: Option<String>,
 }
 
-impl From<std::process::ExitStatus> for ChildStatus {
-  fn from(status: ExitStatus) -> Self {
+impl TryFrom<std::process::ExitStatus> for ChildStatus {
+  type Error = AnyError;
+
+  fn try_from(status: ExitStatus) -> Result<Self, Self::Error> {
     let code = status.code();
     #[cfg(unix)]
     let signal = status.signal();
     #[cfg(not(unix))]
-    let signal = None;
+    let signal: Option<i32> = None;
 
-    if let Some(signal) = signal {
+    let status = if let Some(signal) = signal {
       ChildStatus {
         success: false,
         code: 128 + signal,
-        signal: Some(signal),
+        #[cfg(unix)]
+        signal: Some(
+          crate::ops::signal::signal_int_to_str(signal)?.to_string(),
+        ),
+        #[cfg(not(unix))]
+        signal: None,
       }
     } else {
       let code = code.expect("Should have either an exit code or a signal.");
@@ -98,7 +105,9 @@ impl From<std::process::ExitStatus> for ChildStatus {
         code,
         signal: None,
       }
-    }
+    };
+
+    Ok(status)
   }
 }
 
@@ -219,15 +228,13 @@ async fn op_spawn_wait(
     .borrow_mut()
     .resource_table
     .take::<ChildResource>(rid)?;
-  Ok(
-    Rc::try_unwrap(resource)
-      .ok()
-      .unwrap()
-      .0
-      .wait()
-      .await?
-      .into(),
-  )
+  Rc::try_unwrap(resource)
+    .ok()
+    .unwrap()
+    .0
+    .wait()
+    .await?
+    .try_into()
 }
 
 #[op]
@@ -240,7 +247,7 @@ fn op_spawn_sync(
   let output = create_command(state, args)?.output()?;
 
   Ok(SpawnOutput {
-    status: output.status.into(),
+    status: output.status.try_into()?,
     stdout: if stdout {
       Some(output.stdout.into())
     } else {