summaryrefslogtreecommitdiff
path: root/runtime/ops/fs.rs
diff options
context:
space:
mode:
authorDivy Srivastava <dj.srivastava23@gmail.com>2023-01-14 05:45:30 -0800
committerGitHub <noreply@github.com>2023-01-14 13:45:30 +0000
commitae2981d7acea79f3513b273ccf1cd2dc9d4dbbda (patch)
tree3a0110344f84ac40fe714d8b2d26de06577522aa /runtime/ops/fs.rs
parent68782346d0fb8146ab0eb9e9f4fbd0900d62a85d (diff)
fix(runtime/fs): preserve permissions in copyFileSync for macOS (#17412)
Fixes https://github.com/denoland/deno/issues/16921
Diffstat (limited to 'runtime/ops/fs.rs')
-rw-r--r--runtime/ops/fs.rs21
1 files changed, 19 insertions, 2 deletions
diff --git a/runtime/ops/fs.rs b/runtime/ops/fs.rs
index fe263d944..2f62e143b 100644
--- a/runtime/ops/fs.rs
+++ b/runtime/ops/fs.rs
@@ -881,6 +881,8 @@ fn op_copy_file_sync(
use libc::unlink;
use std::ffi::CString;
use std::io::Read;
+ use std::os::unix::fs::OpenOptionsExt;
+ use std::os::unix::fs::PermissionsExt;
let from = CString::new(from).unwrap();
let to = CString::new(to).unwrap();
@@ -909,8 +911,23 @@ fn op_copy_file_sync(
let mut buf = [0u8; 128 * 1024];
let mut from_file =
std::fs::File::open(&from_path).map_err(err_mapper)?;
- let mut to_file =
- std::fs::File::create(&to_path).map_err(err_mapper)?;
+ let perm = from_file.metadata().map_err(err_mapper)?.permissions();
+
+ let mut to_file = std::fs::OpenOptions::new()
+ // create the file with the correct mode right away
+ .mode(perm.mode())
+ .write(true)
+ .create(true)
+ .truncate(true)
+ .open(&to_path)
+ .map_err(err_mapper)?;
+ let writer_metadata = to_file.metadata()?;
+ if writer_metadata.is_file() {
+ // Set the correct file permissions, in case the file already existed.
+ // Don't set the permissions on already existing non-files like
+ // pipes/FIFOs or device nodes.
+ to_file.set_permissions(perm)?;
+ }
loop {
let nread = from_file.read(&mut buf).map_err(err_mapper)?;
if nread == 0 {