diff options
| author | Bartek Iwańczuk <biwanczuk@gmail.com> | 2023-10-09 00:12:59 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-08 22:12:59 +0000 |
| commit | dfc254cd57683f394f1b5fdca8c75200b2a9969d (patch) | |
| tree | 25315d8183196486dbebae9d83dd7d2b00a65cec /runtime/js | |
| parent | d41d3b8e2f6079d806fb4bc4845b9ad681c20f00 (diff) | |
fix: define window.name (#20804)
Closes https://github.com/denoland/deno/issues/20750
This matches what browsers do:
https://developer.mozilla.org/en-US/docs/Web/API/Window/name
In the future we might want to change the behavior to actually update
the process name, but that needs a bit of discussion regarding if
it needs a permission flag (that would make polyfiling `process.title`
setter really easy too).
Diffstat (limited to 'runtime/js')
| -rw-r--r-- | runtime/js/99_main.js | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/runtime/js/99_main.js b/runtime/js/99_main.js index d2a28838a..ccc61036a 100644 --- a/runtime/js/99_main.js +++ b/runtime/js/99_main.js @@ -489,6 +489,10 @@ function bootstrapMainRuntime(runtimeOptions) { } ObjectDefineProperties(globalThis, mainRuntimeGlobalProperties); ObjectDefineProperties(globalThis, { + // TODO(bartlomieju): in the future we might want to change the + // behavior of setting `name` to actually update the process name. + // Empty string matches what browsers do. + name: util.writable(""), close: util.writable(windowClose), closed: util.getterOnly(() => windowIsClosing), }); |