refactor: Remove PrettyJsError and js_error_create_fn (#14378)

This commit:
- removes "fmt_errors::PrettyJsError" in favor of "format_js_error" fn
- removes "deno_core::JsError::create" and 
"deno_core::RuntimeOptions::js_error_create_fn"
- adds new option to "deno_runtime::ops::worker_host::init"

1 files changed, 4 insertions, 5 deletions

diff --git a/runtime/js/11_workers.js b/runtime/js/11_workers.js
index 5b8d03e71..87949c1c0 100644
--- a/runtime/js/11_workers.js
+++ b/runtime/js/11_workers.js
@@ -134,17 +134,16 @@
       const event = new ErrorEvent("error", {
         cancelable: true,
         message: e.message,
-        lineno: e.lineNumber ? e.lineNumber + 1 : undefined,
-        colno: e.columnNumber ? e.columnNumber + 1 : undefined,
+        lineno: e.lineNumber ? e.lineNumber : undefined,
+        colno: e.columnNumber ? e.columnNumber : undefined,
         filename: e.fileName,
         error: null,
       });
 
       this.dispatchEvent(event);
       // Don't bubble error event to window for loader errors (`!e.fileName`).
-      // TODO(nayeemrmn): Currently these are never bubbled because worker
-      // error event fields aren't populated correctly and `e.fileName` is
-      // always empty.
+      // TODO(nayeemrmn): It's not correct to use `e.fileName` to detect user
+      // errors. It won't be there for non-awaited async ops for example.
       if (e.fileName && !event.defaultPrevented) {
         window.dispatchEvent(event);
       }