diff options
| author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2023-03-04 22:31:38 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-05 02:31:38 +0000 |
| commit | b40086fd7da3729d1d59b312c89ee57747fc66a9 (patch) | |
| tree | 991583010635feab13fae77e7c8a35fef0a09095 /runtime/js/99_main.js | |
| parent | 01028fcdf4f379a7285cc15079306e3ac31edcc1 (diff) | |
refactor(core): include_js_files! 'dir' option doesn't change specifiers (#18019)
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.
Example:
```
include_js_files! {
dir "js",
"hello.js",
}
```
The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.
The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".
Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
Diffstat (limited to 'runtime/js/99_main.js')
| -rw-r--r-- | runtime/js/99_main.js | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/runtime/js/99_main.js b/runtime/js/99_main.js index ffb479c32..58465f3a2 100644 --- a/runtime/js/99_main.js +++ b/runtime/js/99_main.js @@ -39,12 +39,12 @@ const { WeakMapPrototypeGet, WeakMapPrototypeSet, } = primordials; -import * as util from "internal:runtime/js/06_util.js"; +import * as util from "internal:runtime/06_util.js"; import * as event from "internal:deno_web/02_event.js"; import * as location from "internal:deno_web/12_location.js"; -import * as build from "internal:runtime/js/01_build.js"; -import * as version from "internal:runtime/js/01_version.ts"; -import * as os from "internal:runtime/js/30_os.js"; +import * as build from "internal:runtime/01_build.js"; +import * as version from "internal:runtime/01_version.ts"; +import * as os from "internal:runtime/30_os.js"; import * as timers from "internal:deno_web/02_timers.js"; import * as colors from "internal:deno_console/01_colors.js"; import * as net from "internal:deno_net/01_net.js"; @@ -57,8 +57,8 @@ import * as performance from "internal:deno_web/15_performance.js"; import * as url from "internal:deno_url/00_url.js"; import * as fetch from "internal:deno_fetch/26_fetch.js"; import * as messagePort from "internal:deno_web/13_message_port.js"; -import { denoNs, denoNsUnstable } from "internal:runtime/js/90_deno_ns.js"; -import { errors } from "internal:runtime/js/01_errors.js"; +import { denoNs, denoNsUnstable } from "internal:runtime/90_deno_ns.js"; +import { errors } from "internal:runtime/01_errors.js"; import * as webidl from "internal:deno_webidl/00_webidl.js"; import DOMException from "internal:deno_web/01_dom_exception.js"; import * as flash from "internal:deno_flash/01_http.js"; @@ -70,7 +70,7 @@ import { unstableWindowOrWorkerGlobalScope, windowOrWorkerGlobalScope, workerRuntimeGlobalProperties, -} from "internal:runtime/js/98_global_scope.js"; +} from "internal:runtime/98_global_scope.js"; let windowIsClosing = false; let globalThis_; |
