summaryrefslogtreecommitdiff
path: root/runtime/js/40_signals.js
diff options
context:
space:
mode:
authorBartek IwaƄczuk <biwanczuk@gmail.com>2021-11-25 19:49:09 +0100
committerGitHub <noreply@github.com>2021-11-25 19:49:09 +0100
commitf3c0f0565bbf43b4cc31979b05e729d4f4a1538f (patch)
tree6554dfdecd89e076166531b91824d6750d5b76e0 /runtime/js/40_signals.js
parent2853e3760471560c1812b46007e1a525966b1365 (diff)
feat(core): Add ability to "ref" and "unref" pending ops (#12889)
This commit adds an ability to "ref" or "unref" pending ops. Up to this point Deno had a notion of "async ops" and "unref async ops"; the former keep event loop alive, while the latter do not block event loop from finishing. It was not possible to change between op types after dispatching, one had to decide which type to use before dispatch. Instead of storing ops in two separate "FuturesUnordered" collections, now ops are stored in a single collection, with supplemental "HashSet" storing ids of promises that were "unrefed". Two APIs were added to "Deno.core": "Deno.core.refOp(promiseId)" which allows to mark promise id to be "refed" and keep event loop alive (the default behavior) "Deno.core.unrefOp(promiseId)" which allows to mark promise id as "unrefed" which won't block event loop from exiting
Diffstat (limited to 'runtime/js/40_signals.js')
-rw-r--r--runtime/js/40_signals.js5
1 files changed, 4 insertions, 1 deletions
diff --git a/runtime/js/40_signals.js b/runtime/js/40_signals.js
index a4f3a6ccd..2498c40d7 100644
--- a/runtime/js/40_signals.js
+++ b/runtime/js/40_signals.js
@@ -5,6 +5,7 @@
const core = window.Deno.core;
const {
Set,
+ SymbolFor,
TypeError,
} = window.__bootstrap.primordials;
@@ -13,7 +14,9 @@
}
function pollSignal(rid) {
- return core.opAsync("op_signal_poll", rid);
+ const promise = core.opAsync("op_signal_poll", rid);
+ core.unrefOp(promise[SymbolFor("Deno.core.internalPromiseId")]);
+ return promise;
}
function unbindSignal(rid) {