diff options
author | Aapo Alasuutari <aapo.alasuutari@gmail.com> | 2022-08-11 16:56:56 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-08-11 15:56:56 +0200 |
commit | 2164f6b1eb7216c1045d547c94f26fe3ceaa9403 (patch) | |
tree | 056e3d6540ebd0e755650765adcff6b5cc173db8 /runtime/js/30_os.js | |
parent | 883269f1f183428f60c54223135d8dd25977b3cd (diff) |
perf(ops): Monomorphic sync op calls (#15337)
Welcome to better optimised op calls! Currently opSync is called with parameters of every type and count. This most definitely makes the call megamorphic. Additionally, it seems that spread params leads to V8 not being able to optimise the calls quite as well (apparently Fast Calls cannot be used with spread params).
Monomorphising op calls should lead to some improved performance. Now that unwrapping of sync ops results is done on Rust side, this is pretty simple:
```
opSync("op_foo", param1, param2);
// -> turns to
ops.op_foo(param1, param2);
```
This means sync op calls are now just directly calling the native binding function. When V8 Fast API Calls are enabled, this will enable those to be called on the optimised path.
Monomorphising async ops likely requires using callbacks and is left as an exercise to the reader.
Diffstat (limited to 'runtime/js/30_os.js')
-rw-r--r-- | runtime/js/30_os.js | 29 |
1 files changed, 15 insertions, 14 deletions
diff --git a/runtime/js/30_os.js b/runtime/js/30_os.js index f9df42305..c3addd043 100644 --- a/runtime/js/30_os.js +++ b/runtime/js/30_os.js @@ -3,6 +3,7 @@ ((window) => { const core = window.Deno.core; + const ops = core.ops; const { Error, SymbolFor, @@ -11,31 +12,31 @@ const windowDispatchEvent = window.dispatchEvent.bind(window); function loadavg() { - return core.opSync("op_loadavg"); + return ops.op_loadavg(); } function hostname() { - return core.opSync("op_hostname"); + return ops.op_hostname(); } function osRelease() { - return core.opSync("op_os_release"); + return ops.op_os_release(); } function systemMemoryInfo() { - return core.opSync("op_system_memory_info"); + return ops.op_system_memory_info(); } function networkInterfaces() { - return core.opSync("op_network_interfaces"); + return ops.op_network_interfaces(); } function getGid() { - return core.opSync("op_getgid"); + return ops.op_getgid(); } function getUid() { - return core.opSync("op_getuid"); + return ops.op_getuid(); } // This is an internal only method used by the test harness to override the @@ -48,7 +49,7 @@ function exit(code) { // Set exit code first so unload event listeners can override it. if (typeof code === "number") { - core.opSync("op_set_exit_code", code); + ops.op_set_exit_code(code); } else { code = 0; } @@ -65,33 +66,33 @@ return; } - core.opSync("op_exit"); + ops.op_exit(); throw new Error("Code not reachable"); } function setEnv(key, value) { - core.opSync("op_set_env", key, value); + ops.op_set_env(key, value); } function getEnv(key) { - return core.opSync("op_get_env", key) ?? undefined; + return ops.op_get_env(key) ?? undefined; } function deleteEnv(key) { - core.opSync("op_delete_env", key); + ops.op_delete_env(key); } const env = { get: getEnv, toObject() { - return core.opSync("op_env"); + return ops.op_env(); }, set: setEnv, delete: deleteEnv, }; function execPath() { - return core.opSync("op_exec_path"); + return ops.op_exec_path(); } window.__bootstrap.os = { |