diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2024-05-08 22:45:06 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-08 22:45:06 -0400 |
| commit | 47f7bed677a6b72e873712de8f3988ea891710e4 (patch) | |
| tree | 096549459b479cf1383e65c87b77e9f9482df258 /runtime/inspector_server.rs | |
| parent | e6dc4dfbff25e77d2127591802229b4a74037d24 (diff) | |
chore: enable clippy::print_stdout and clippy::print_stderr (#23732)
1. Generally we should prefer to use the `log` crate.
2. I very often accidentally commit `eprintln`s.
When we should use `println` or `eprintln`, it's not too bad to be a bit
more verbose and ignore the lint rule.
Diffstat (limited to 'runtime/inspector_server.rs')
| -rw-r--r-- | runtime/inspector_server.rs | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/runtime/inspector_server.rs b/runtime/inspector_server.rs index 8d93819e9..48d8e0a8f 100644 --- a/runtime/inspector_server.rs +++ b/runtime/inspector_server.rs @@ -176,7 +176,7 @@ fn handle_ws_request( let websocket = match fut.await { Ok(w) => w, Err(err) => { - eprintln!( + log::error!( "Inspector server failed to upgrade to WS connection: {:?}", err ); @@ -194,7 +194,7 @@ fn handle_ws_request( rx: inbound_rx, }; - eprintln!("Debugger session started."); + log::info!("Debugger session started."); let _ = new_session_tx.unbounded_send(inspector_session_proxy); pump_websocket_messages(websocket, inbound_tx, outbound_rx).await; }); @@ -244,13 +244,13 @@ async fn server( let inspector_map = Rc::clone(&inspector_map_); let mut register_inspector_handler = pin!(register_inspector_rx .map(|info| { - eprintln!( + log::info!( "Debugger listening on {}", info.get_websocket_debugger_url(&info.host.to_string()) ); - eprintln!("Visit chrome://inspect to connect to the debugger."); + log::info!("Visit chrome://inspect to connect to the debugger."); if info.wait_for_session { - eprintln!("Deno is waiting for debugger to connect."); + log::info!("Deno is waiting for debugger to connect."); } if inspector_map.borrow_mut().insert(info.uuid, info).is_some() { panic!("Inspector UUID already in map"); @@ -277,7 +277,7 @@ async fn server( let listener = match TcpListener::from_std(listener) { Ok(l) => l, Err(err) => { - eprintln!("Cannot start inspector server: {:?}", err); + log::error!("Cannot start inspector server: {:?}", err); return; } }; @@ -293,7 +293,7 @@ async fn server( match accept_result { Ok((s, _)) => s, Err(err) => { - eprintln!("Failed to accept inspector connection: {:?}", err); + log::error!("Failed to accept inspector connection: {:?}", err); continue; } } @@ -356,7 +356,7 @@ async fn server( tokio::select! { result = conn.as_mut() => { if let Err(err) = result { - eprintln!("Failed to serve connection: {:?}", err); + log::error!("Failed to serve connection: {:?}", err); } }, _ = &mut shutdown_rx => { @@ -409,7 +409,7 @@ async fn pump_websocket_messages( OpCode::Close => { // Users don't care if there was an error coming from debugger, // just about the fact that debugger did disconnect. - eprintln!("Debugger session ended"); + log::info!("Debugger session ended"); break 'pump; } _ => { |