diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2024-11-13 10:10:09 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-11-13 15:10:09 +0000 |
| commit | f091d1ad69b4e5217ae3272b641171781a372c4f (patch) | |
| tree | 4ef4f90ec8a6b5c977efb187449f8c59c45de5e1 /resolvers/node/package_json.rs | |
| parent | 6a4c6d83bacf5f03628a494778a30bce970f7cbc (diff) | |
feat(node): stabilize detecting if CJS via `"type": "commonjs"` in a package.json (#26439)
This will respect `"type": "commonjs"` in a package.json to determine if
`.js`/`.jsx`/`.ts`/.tsx` files are CJS or ESM. If the file is found to
be ESM it will be loaded as ESM though.
Diffstat (limited to 'resolvers/node/package_json.rs')
| -rw-r--r-- | resolvers/node/package_json.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/resolvers/node/package_json.rs b/resolvers/node/package_json.rs index 6967779e5..ae016ebe3 100644 --- a/resolvers/node/package_json.rs +++ b/resolvers/node/package_json.rs @@ -15,8 +15,8 @@ use crate::errors::CanonicalizingPkgJsonDirError; use crate::errors::ClosestPkgJsonError; use crate::errors::PackageJsonLoadError; -// todo(dsherret): this isn't exactly correct and we should change it to instead -// be created per worker and passed down as a ctor arg to the pkg json resolver +// it would be nice if this was passed down as a ctor arg to the package.json resolver, +// but it's a little bit complicated to do that, so we just maintain a thread local cache thread_local! { static CACHE: RefCell<HashMap<PathBuf, PackageJsonRc>> = RefCell::new(HashMap::new()); } |