Revert "feat(ops): Fast zero copy string arguments (#16777)" (#17063)

This reverts commit 9b2b8df927ac23cfa99016a684179f2a3198ba2e.

Closes https://github.com/dsherret/ts-morph/issues/1372
Closes https://github.com/denoland/deno/issues/16979

18 files changed, 8 insertions, 683 deletions

diff --git a/ops/fast_call.rs b/ops/fast_call.rs
index 1d6bfa1fa..f2ed8cb2d 100644
--- a/ops/fast_call.rs
+++ b/ops/fast_call.rs
@@ -403,9 +403,7 @@ fn q_fast_ty(v: &FastValue) -> Quote {
     FastValue::F64 => q!({ f64 }),
     FastValue::Bool => q!({ bool }),
     FastValue::V8Value => q!({ v8::Local<v8::Value> }),
-    FastValue::Uint8Array
-    | FastValue::Uint32Array
-    | FastValue::SeqOneByteString => unreachable!(),
+    FastValue::Uint8Array | FastValue::Uint32Array => unreachable!(),
   }
 }
 
@@ -423,7 +421,6 @@ fn q_fast_ty_variant(v: &FastValue) -> Quote {
     FastValue::V8Value => q!({ V8Value }),
     FastValue::Uint8Array => q!({ TypedArray(CType::Uint8) }),
     FastValue::Uint32Array => q!({ TypedArray(CType::Uint32) }),
-    FastValue::SeqOneByteString => q!({ SeqOneByteString }),
   }
 }
 
diff --git a/ops/lib.rs b/ops/lib.rs
index 7fa800b14..b4bef1d13 100644
--- a/ops/lib.rs
+++ b/ops/lib.rs
@@ -411,12 +411,7 @@ fn codegen_arg(
     return quote! { let #ident = (); };
   }
   // Fast path for `String`
-  if let Some(is_ref) = is_string(&**ty) {
-    let ref_block = if is_ref {
-      quote! { let #ident = #ident.as_ref(); }
-    } else {
-      quote! {}
-    };
+  if is_string(&**ty) {
     return quote! {
       let #ident = match #core::v8::Local::<#core::v8::String>::try_from(args.get(#idx as i32)) {
         Ok(v8_string) => #core::serde_v8::to_utf8(v8_string, scope),
@@ -424,18 +419,6 @@ fn codegen_arg(
           return #core::_ops::throw_type_error(scope, format!("Expected string at position {}", #idx));
         }
       };
-      #ref_block
-    };
-  }
-  // Fast path for `Cow<'_, str>`
-  if is_cow_str(&**ty) {
-    return quote! {
-      let #ident = match #core::v8::Local::<#core::v8::String>::try_from(args.get(#idx as i32)) {
-        Ok(v8_string) => ::std::borrow::Cow::Owned(#core::serde_v8::to_utf8(v8_string, scope)),
-        Err(_) => {
-          return #core::_ops::throw_type_error(scope, format!("Expected string at position {}", #idx));
-        }
-      };
     };
   }
   // Fast path for `Option<String>`
@@ -646,25 +629,14 @@ fn is_result(ty: impl ToTokens) -> bool {
   }
 }
 
-fn is_string(ty: impl ToTokens) -> Option<bool> {
-  let toks = tokens(ty);
-  if toks == "String" {
-    return Some(false);
-  }
-  if toks == "& str" {
-    return Some(true);
-  }
-  None
+fn is_string(ty: impl ToTokens) -> bool {
+  tokens(ty) == "String"
 }
 
 fn is_option_string(ty: impl ToTokens) -> bool {
   tokens(ty) == "Option < String >"
 }
 
-fn is_cow_str(ty: impl ToTokens) -> bool {
-  tokens(&ty).starts_with("Cow <") && tokens(&ty).ends_with("str >")
-}
-
 enum SliceType {
   U8,
   U8Mut,
diff --git a/ops/optimizer.rs b/ops/optimizer.rs
index 99de4b424..2d68a296f 100644
--- a/ops/optimizer.rs
+++ b/ops/optimizer.rs
@@ -20,19 +20,11 @@ pub(crate) enum BailoutReason {
 }
 
 #[derive(Debug, PartialEq)]
-enum StringType {
-  Cow,
-  Ref,
-  Owned,
-}
-
-#[derive(Debug, PartialEq)]
 enum TransformKind {
   // serde_v8::Value
   V8Value,
   SliceU32(bool),
   SliceU8(bool),
-  SeqOneByteString(StringType),
   PtrU8,
   WasmMemory,
 }
@@ -59,13 +51,6 @@ impl Transform {
     }
   }
 
-  fn seq_one_byte_string(index: usize, is_ref: StringType) -> Self {
-    Transform {
-      kind: TransformKind::SeqOneByteString(is_ref),
-      index,
-    }
-  }
-
   fn wasm_memory(index: usize) -> Self {
     Transform {
       kind: TransformKind::WasmMemory,
@@ -147,21 +132,6 @@ impl Transform {
           };
         })
       }
-      // &str
-      TransformKind::SeqOneByteString(str_ty) => {
-        *ty = parse_quote! { *const #core::v8::fast_api::FastApiOneByteString };
-        match str_ty {
-          StringType::Ref => q!(Vars { var: &ident }, {
-            let var = unsafe { &*var }.as_str();
-          }),
-          StringType::Cow => q!(Vars { var: &ident }, {
-            let var = ::std::borrow::Cow::Borrowed(unsafe { &*var }.as_str());
-          }),
-          StringType::Owned => q!(Vars { var: &ident }, {
-            let var = unsafe { &*var }.as_str().to_owned();
-          }),
-        }
-      }
       TransformKind::WasmMemory => {
         // Note: `ty` is correctly set to __opts by the fast call tier.
         q!(Vars { var: &ident, core }, {
@@ -228,7 +198,6 @@ pub(crate) enum FastValue {
   V8Value,
   Uint8Array,
   Uint32Array,
-  SeqOneByteString,
 }
 
 impl Default for FastValue {
@@ -581,58 +550,10 @@ impl Optimizer {
                 }
               }
             }
-            // Cow<'_, str>
-            PathSegment {
-              ident, arguments, ..
-            } if ident == "Cow" => {
-              if let PathArguments::AngleBracketed(
-                AngleBracketedGenericArguments { args, .. },
-              ) = arguments
-              {
-                assert_eq!(args.len(), 2);
-
-                let ty = &args[1];
-                match ty {
-                  GenericArgument::Type(Type::Path(TypePath {
-                    path: Path { segments, .. },
-                    ..
-                  })) => {
-                    let segment = single_segment(segments)?;
-                    match segment {
-                      PathSegment { ident, .. } if ident == "str" => {
-                        self.fast_parameters.push(FastValue::SeqOneByteString);
-                        assert!(self
-                          .transforms
-                          .insert(
-                            index,
-                            Transform::seq_one_byte_string(
-                              index,
-                              StringType::Cow
-                            )
-                          )
-                          .is_none());
-                      }
-                      _ => return Err(BailoutReason::FastUnsupportedParamType),
-                    }
-                  }
-                  _ => return Err(BailoutReason::FastUnsupportedParamType),
-                }
-              }
-            }
             // Is `T` a fast scalar?
             PathSegment { ident, .. } => {
               if let Some(val) = get_fast_scalar(ident.to_string().as_str()) {
                 self.fast_parameters.push(val);
-              } else if ident == "String" {
-                // Is `T` an owned String?
-                self.fast_parameters.push(FastValue::SeqOneByteString);
-                assert!(self
-                  .transforms
-                  .insert(
-                    index,
-                    Transform::seq_one_byte_string(index, StringType::Owned)
-                  )
-                  .is_none());
               } else {
                 return Err(BailoutReason::FastUnsupportedParamType);
               }
@@ -655,17 +576,6 @@ impl Optimizer {
               {
                 self.has_ref_opstate = true;
               }
-              // Is `T` a str?
-              PathSegment { ident, .. } if ident == "str" => {
-                self.fast_parameters.push(FastValue::SeqOneByteString);
-                assert!(self
-                  .transforms
-                  .insert(
-                    index,
-                    Transform::seq_one_byte_string(index, StringType::Ref)
-                  )
-                  .is_none());
-              }
               _ => return Err(BailoutReason::FastUnsupportedParamType),
             }
           }
diff --git a/ops/optimizer_tests/cow_str.expected b/ops/optimizer_tests/cow_str.expected
deleted file mode 100644
index 8b28965ba..000000000
--- a/ops/optimizer_tests/cow_str.expected
+++ /dev/null
@@ -1,11 +0,0 @@
-=== Optimizer Dump ===
-returns_result: false
-has_ref_opstate: false
-has_rc_opstate: false
-has_fast_callback_option: false
-needs_fast_callback_option: false
-fast_result: Some(Void)
-fast_parameters: [V8Value, SeqOneByteString]
-transforms: {0: Transform { kind: SeqOneByteString(Cow), index: 0 }}
-is_async: false
-fast_compatible: true
diff --git a/ops/optimizer_tests/cow_str.out b/ops/optimizer_tests/cow_str.out
deleted file mode 100644
index da405f451..000000000
--- a/ops/optimizer_tests/cow_str.out
+++ /dev/null
@@ -1,87 +0,0 @@
-#[allow(non_camel_case_types)]
-///Auto-generated by `deno_ops`, i.e: `#[op]`
-///
-///Use `op_cow_str::decl()` to get an op-declaration
-///you can include in a `deno_core::Extension`.
-pub struct op_cow_str;
-#[doc(hidden)]
-impl op_cow_str {
-    pub fn name() -> &'static str {
-        stringify!(op_cow_str)
-    }
-    pub fn v8_fn_ptr<'scope>() -> deno_core::v8::FunctionCallback {
-        use deno_core::v8::MapFnTo;
-        Self::v8_func.map_fn_to()
-    }
-    pub fn decl<'scope>() -> deno_core::OpDecl {
-        deno_core::OpDecl {
-            name: Self::name(),
-            v8_fn_ptr: Self::v8_fn_ptr(),
-            enabled: true,
-            fast_fn: Some(
-                Box::new(op_cow_str_fast {
-                    _phantom: ::std::marker::PhantomData,
-                }),
-            ),
-            is_async: false,
-            is_unstable: false,
-            is_v8: false,
-            argc: 1usize,
-        }
-    }
-    #[inline]
-    #[allow(clippy::too_many_arguments)]
-    fn call(c: Cow<'_, str>) {}
-    pub fn v8_func<'scope>(
-        scope: &mut deno_core::v8::HandleScope<'scope>,
-        args: deno_core::v8::FunctionCallbackArguments,
-        mut rv: deno_core::v8::ReturnValue,
-    ) {
-        let ctx = unsafe {
-            &*(deno_core::v8::Local::<deno_core::v8::External>::cast(args.data()).value()
-                as *const deno_core::_ops::OpCtx)
-        };
-        let arg_0 = match deno_core::v8::Local::<
-            deno_core::v8::String,
-        >::try_from(args.get(0usize as i32)) {
-            Ok(v8_string) => {
-                ::std::borrow::Cow::Owned(deno_core::serde_v8::to_utf8(v8_string, scope))
-            }
-            Err(_) => {
-                return deno_core::_ops::throw_type_error(
-                    scope,
-                    format!("Expected string at position {}", 0usize),
-                );
-            }
-        };
-        let result = Self::call(arg_0);
-        let op_state = ::std::cell::RefCell::borrow(&*ctx.state);
-        op_state.tracker.track_sync(ctx.id);
-    }
-}
-struct op_cow_str_fast {
-    _phantom: ::std::marker::PhantomData<()>,
-}
-impl<'scope> deno_core::v8::fast_api::FastFunction for op_cow_str_fast {
-    fn function(&self) -> *const ::std::ffi::c_void {
-        op_cow_str_fast_fn as *const ::std::ffi::c_void
-    }
-    fn args(&self) -> &'static [deno_core::v8::fast_api::Type] {
-        use deno_core::v8::fast_api::Type::*;
-        use deno_core::v8::fast_api::CType;
-        &[V8Value, SeqOneByteString]
-    }
-    fn return_type(&self) -> deno_core::v8::fast_api::CType {
-        deno_core::v8::fast_api::CType::Void
-    }
-}
-fn op_cow_str_fast_fn<'scope>(
-    _: deno_core::v8::Local<deno_core::v8::Object>,
-    c: *const deno_core::v8::fast_api::FastApiOneByteString,
-) -> () {
-    use deno_core::v8;
-    use deno_core::_ops;
-    let c = ::std::borrow::Cow::Borrowed(unsafe { &*c }.as_str());
-    let result = op_cow_str::call(c);
-    result
-}
diff --git a/ops/optimizer_tests/cow_str.rs b/ops/optimizer_tests/cow_str.rs
deleted file mode 100644
index b7214bdc7..000000000
--- a/ops/optimizer_tests/cow_str.rs
+++ /dev/null
@@ -1,3 +0,0 @@
-fn op_cow_str(c: Cow<'_, str>) {
-  // ...
-}
diff --git a/ops/optimizer_tests/op_blob_revoke_object_url.expected b/ops/optimizer_tests/op_blob_revoke_object_url.expected
index 5b3e43edc..0fae25e86 100644
--- a/ops/optimizer_tests/op_blob_revoke_object_url.expected
+++ b/ops/optimizer_tests/op_blob_revoke_object_url.expected
@@ -1,11 +1 @@
-=== Optimizer Dump ===
-returns_result: true
-has_ref_opstate: true
-has_rc_opstate: false
-has_fast_callback_option: false
-needs_fast_callback_option: false
-fast_result: Some(Void)
-fast_parameters: [V8Value, SeqOneByteString]
-transforms: {1: Transform { kind: SeqOneByteString(Owned), index: 1 }}
-is_async: false
-fast_compatible: true
+MustBeSingleSegment
\ No newline at end of file
diff --git a/ops/optimizer_tests/op_blob_revoke_object_url.out b/ops/optimizer_tests/op_blob_revoke_object_url.out
index 28fe17acb..72bc75e05 100644
--- a/ops/optimizer_tests/op_blob_revoke_object_url.out
+++ b/ops/optimizer_tests/op_blob_revoke_object_url.out
@@ -18,11 +18,7 @@ impl op_blob_revoke_object_url {
             name: Self::name(),
             v8_fn_ptr: Self::v8_fn_ptr(),
             enabled: true,
-            fast_fn: Some(
-                Box::new(op_blob_revoke_object_url_fast {
-                    _phantom: ::std::marker::PhantomData,
-                }),
-            ),
+            fast_fn: None,
             is_async: false,
             is_unstable: false,
             is_v8: false,
@@ -31,7 +27,7 @@ impl op_blob_revoke_object_url {
     }
     #[inline]
     #[allow(clippy::too_many_arguments)]
-    pub fn call(state: &mut OpState, url: String) -> Result<(), AnyError> {
+    pub fn call(state: &mut deno_core::OpState, url: String) -> Result<(), AnyError> {
         let url = Url::parse(&url)?;
         let blob_store = state.borrow::<BlobStore>();
         blob_store.remove_object_url(&url);
@@ -46,18 +42,6 @@ impl op_blob_revoke_object_url {
             &*(deno_core::v8::Local::<deno_core::v8::External>::cast(args.data()).value()
                 as *const deno_core::_ops::OpCtx)
         };
-        {
-            let op_state = &mut std::cell::RefCell::borrow_mut(&ctx.state);
-            if let Some(err) = op_state.last_fast_op_error.take() {
-                let exception = deno_core::error::to_v8_error(
-                    scope,
-                    op_state.get_error_class_fn,
-                    &err,
-                );
-                scope.throw_exception(exception);
-                return;
-            }
-        }
         let arg_0 = match deno_core::v8::Local::<
             deno_core::v8::String,
         >::try_from(args.get(0usize as i32)) {
@@ -85,45 +69,3 @@ impl op_blob_revoke_object_url {
         };
     }
 }
-struct op_blob_revoke_object_url_fast {
-    _phantom: ::std::marker::PhantomData<()>,
-}
-impl<'scope> deno_core::v8::fast_api::FastFunction for op_blob_revoke_object_url_fast {
-    fn function(&self) -> *const ::std::ffi::c_void {
-        op_blob_revoke_object_url_fast_fn as *const ::std::ffi::c_void
-    }
-    fn args(&self) -> &'static [deno_core::v8::fast_api::Type] {
-        use deno_core::v8::fast_api::Type::*;
-        use deno_core::v8::fast_api::CType;
-        &[V8Value, SeqOneByteString, CallbackOptions]
-    }
-    fn return_type(&self) -> deno_core::v8::fast_api::CType {
-        deno_core::v8::fast_api::CType::Void
-    }
-}
-fn op_blob_revoke_object_url_fast_fn<'scope>(
-    _: deno_core::v8::Local<deno_core::v8::Object>,
-    url: *const deno_core::v8::fast_api::FastApiOneByteString,
-    fast_api_callback_options: *mut deno_core::v8::fast_api::FastApiCallbackOptions,
-) -> () {
-    use deno_core::v8;
-    use deno_core::_ops;
-    let __opts: &mut v8::fast_api::FastApiCallbackOptions = unsafe {
-        &mut *fast_api_callback_options
-    };
-    let __ctx = unsafe {
-        &*(v8::Local::<v8::External>::cast(unsafe { __opts.data.data }).value()
-            as *const _ops::OpCtx)
-    };
-    let state = &mut ::std::cell::RefCell::borrow_mut(&__ctx.state);
-    let url = unsafe { &*url }.as_str().to_owned();
-    let result = op_blob_revoke_object_url::call(state, url);
-    match result {
-        Ok(result) => result,
-        Err(err) => {
-            state.last_fast_op_error.replace(err);
-            __opts.fallback = true;
-            Default::default()
-        }
-    }
-}
diff --git a/ops/optimizer_tests/op_blob_revoke_object_url.rs b/ops/optimizer_tests/op_blob_revoke_object_url.rs
index b51a2ed7f..8e139da06 100644
--- a/ops/optimizer_tests/op_blob_revoke_object_url.rs
+++ b/ops/optimizer_tests/op_blob_revoke_object_url.rs
@@ -1,5 +1,5 @@
 pub fn op_blob_revoke_object_url(
-  state: &mut OpState,
+  state: &mut deno_core::OpState,
   url: String,
 ) -> Result<(), AnyError> {
   let url = Url::parse(&url)?;
diff --git a/ops/optimizer_tests/op_print.expected b/ops/optimizer_tests/op_print.expected
deleted file mode 100644
index fb52693aa..000000000
--- a/ops/optimizer_tests/op_print.expected
+++ /dev/null
@@ -1,11 +0,0 @@
-=== Optimizer Dump ===
-returns_result: true
-has_ref_opstate: true
-has_rc_opstate: false
-has_fast_callback_option: false
-needs_fast_callback_option: false
-fast_result: Some(Void)
-fast_parameters: [V8Value, SeqOneByteString, Bool]
-transforms: {1: Transform { kind: SeqOneByteString(Ref), index: 1 }}
-is_async: false
-fast_compatible: true
diff --git a/ops/optimizer_tests/op_print.out b/ops/optimizer_tests/op_print.out
deleted file mode 100644
index 5d0062a01..000000000
--- a/ops/optimizer_tests/op_print.out
+++ /dev/null
@@ -1,141 +0,0 @@
-#[allow(non_camel_case_types)]
-///Auto-generated by `deno_ops`, i.e: `#[op]`
-///
-///Use `op_print::decl()` to get an op-declaration
-///you can include in a `deno_core::Extension`.
-pub struct op_print;
-#[doc(hidden)]
-impl op_print {
-    pub fn name() -> &'static str {
-        stringify!(op_print)
-    }
-    pub fn v8_fn_ptr<'scope>() -> deno_core::v8::FunctionCallback {
-        use deno_core::v8::MapFnTo;
-        Self::v8_func.map_fn_to()
-    }
-    pub fn decl<'scope>() -> deno_core::OpDecl {
-        deno_core::OpDecl {
-            name: Self::name(),
-            v8_fn_ptr: Self::v8_fn_ptr(),
-            enabled: true,
-            fast_fn: Some(
-                Box::new(op_print_fast {
-                    _phantom: ::std::marker::PhantomData,
-                }),
-            ),
-            is_async: false,
-            is_unstable: false,
-            is_v8: false,
-            argc: 2usize,
-        }
-    }
-    #[inline]
-    #[allow(clippy::too_many_arguments)]
-    fn call(state: &mut OpState, msg: &str, is_err: bool) -> Result<(), AnyError> {}
-    pub fn v8_func<'scope>(
-        scope: &mut deno_core::v8::HandleScope<'scope>,
-        args: deno_core::v8::FunctionCallbackArguments,
-        mut rv: deno_core::v8::ReturnValue,
-    ) {
-        let ctx = unsafe {
-            &*(deno_core::v8::Local::<deno_core::v8::External>::cast(args.data()).value()
-                as *const deno_core::_ops::OpCtx)
-        };
-        {
-            let op_state = &mut std::cell::RefCell::borrow_mut(&ctx.state);
-            if let Some(err) = op_state.last_fast_op_error.take() {
-                let exception = deno_core::error::to_v8_error(
-                    scope,
-                    op_state.get_error_class_fn,
-                    &err,
-                );
-                scope.throw_exception(exception);
-                return;
-            }
-        }
-        let arg_0 = match deno_core::v8::Local::<
-            deno_core::v8::String,
-        >::try_from(args.get(0usize as i32)) {
-            Ok(v8_string) => deno_core::serde_v8::to_utf8(v8_string, scope),
-            Err(_) => {
-                return deno_core::_ops::throw_type_error(
-                    scope,
-                    format!("Expected string at position {}", 0usize),
-                );
-            }
-        };
-        let arg_0 = arg_0.as_ref();
-        let arg_1 = args.get(1usize as i32);
-        let arg_1 = match deno_core::serde_v8::from_v8(scope, arg_1) {
-            Ok(v) => v,
-            Err(err) => {
-                let msg = format!(
-                    "Error parsing args at position {}: {}", 1usize,
-                    deno_core::anyhow::Error::from(err)
-                );
-                return deno_core::_ops::throw_type_error(scope, msg);
-            }
-        };
-        let result = Self::call(
-            &mut std::cell::RefCell::borrow_mut(&ctx.state),
-            arg_0,
-            arg_1,
-        );
-        let op_state = ::std::cell::RefCell::borrow(&*ctx.state);
-        op_state.tracker.track_sync(ctx.id);
-        match result {
-            Ok(result) => {}
-            Err(err) => {
-                let exception = deno_core::error::to_v8_error(
-                    scope,
-                    op_state.get_error_class_fn,
-                    &err,
-                );
-                scope.throw_exception(exception);
-            }
-        };
-    }
-}
-struct op_print_fast {
-    _phantom: ::std::marker::PhantomData<()>,
-}
-impl<'scope> deno_core::v8::fast_api::FastFunction for op_print_fast {
-    fn function(&self) -> *const ::std::ffi::c_void {
-        op_print_fast_fn as *const ::std::ffi::c_void
-    }
-    fn args(&self) -> &'static [deno_core::v8::fast_api::Type] {
-        use deno_core::v8::fast_api::Type::*;
-        use deno_core::v8::fast_api::CType;
-        &[V8Value, SeqOneByteString, Bool, CallbackOptions]
-    }
-    fn return_type(&self) -> deno_core::v8::fast_api::CType {
-        deno_core::v8::fast_api::CType::Void
-    }
-}
-fn op_print_fast_fn<'scope>(
-    _: deno_core::v8::Local<deno_core::v8::Object>,
-    msg: *const deno_core::v8::fast_api::FastApiOneByteString,
-    is_err: bool,
-    fast_api_callback_options: *mut deno_core::v8::fast_api::FastApiCallbackOptions,
-) -> () {
-    use deno_core::v8;
-    use deno_core::_ops;
-    let __opts: &mut v8::fast_api::FastApiCallbackOptions = unsafe {
-        &mut *fast_api_callback_options
-    };
-    let __ctx = unsafe {
-        &*(v8::Local::<v8::External>::cast(unsafe { __opts.data.data }).value()
-            as *const _ops::OpCtx)
-    };
-    let state = &mut ::std::cell::RefCell::borrow_mut(&__ctx.state);
-    let msg = unsafe { &*msg }.as_str();
-    let result = op_print::call(state, msg, is_err);
-    match result {
-        Ok(result) => result,
-        Err(err) => {
-            state.last_fast_op_error.replace(err);
-            __opts.fallback = true;
-            Default::default()
-        }
-    }
-}
diff --git a/ops/optimizer_tests/op_print.rs b/ops/optimizer_tests/op_print.rs
deleted file mode 100644
index 516521a0e..000000000
--- a/ops/optimizer_tests/op_print.rs
+++ /dev/null
@@ -1,6 +0,0 @@
-fn op_print(
-  state: &mut OpState,
-  msg: &str,
-  is_err: bool,
-) -> Result<(), AnyError> {
-}
diff --git a/ops/optimizer_tests/owned_string.expected b/ops/optimizer_tests/owned_string.expected
deleted file mode 100644
index a15275412..000000000
--- a/ops/optimizer_tests/owned_string.expected
+++ /dev/null
@@ -1,11 +0,0 @@
-=== Optimizer Dump ===
-returns_result: false
-has_ref_opstate: false
-has_rc_opstate: false
-has_fast_callback_option: false
-needs_fast_callback_option: false
-fast_result: Some(U32)
-fast_parameters: [V8Value, SeqOneByteString]
-transforms: {0: Transform { kind: SeqOneByteString(Owned), index: 0 }}
-is_async: false
-fast_compatible: true
diff --git a/ops/optimizer_tests/owned_string.out b/ops/optimizer_tests/owned_string.out
deleted file mode 100644
index 4892221f8..000000000
--- a/ops/optimizer_tests/owned_string.out
+++ /dev/null
@@ -1,99 +0,0 @@
-#[allow(non_camel_case_types)]
-///Auto-generated by `deno_ops`, i.e: `#[op]`
-///
-///Use `op_string_length::decl()` to get an op-declaration
-///you can include in a `deno_core::Extension`.
-pub struct op_string_length;
-#[doc(hidden)]
-impl op_string_length {
-    pub fn name() -> &'static str {
-        stringify!(op_string_length)
-    }
-    pub fn v8_fn_ptr<'scope>() -> deno_core::v8::FunctionCallback {
-        use deno_core::v8::MapFnTo;
-        Self::v8_func.map_fn_to()
-    }
-    pub fn decl<'scope>() -> deno_core::OpDecl {
-        deno_core::OpDecl {
-            name: Self::name(),
-            v8_fn_ptr: Self::v8_fn_ptr(),
-            enabled: true,
-            fast_fn: Some(
-                Box::new(op_string_length_fast {
-                    _phantom: ::std::marker::PhantomData,
-                }),
-            ),
-            is_async: false,
-            is_unstable: false,
-            is_v8: false,
-            argc: 1usize,
-        }
-    }
-    #[inline]
-    #[allow(clippy::too_many_arguments)]
-    fn call(string: String) -> u32 {
-        string.len() as u32
-    }
-    pub fn v8_func<'scope>(
-        scope: &mut deno_core::v8::HandleScope<'scope>,
-        args: deno_core::v8::FunctionCallbackArguments,
-        mut rv: deno_core::v8::ReturnValue,
-    ) {
-        let ctx = unsafe {
-            &*(deno_core::v8::Local::<deno_core::v8::External>::cast(args.data()).value()
-                as *const deno_core::_ops::OpCtx)
-        };
-        let arg_0 = match deno_core::v8::Local::<
-            deno_core::v8::String,
-        >::try_from(args.get(0usize as i32)) {
-            Ok(v8_string) => deno_core::serde_v8::to_utf8(v8_string, scope),
-            Err(_) => {
-                return deno_core::_ops::throw_type_error(
-                    scope,
-                    format!("Expected string at position {}", 0usize),
-                );
-            }
-        };
-        let result = Self::call(arg_0);
-        let op_state = ::std::cell::RefCell::borrow(&*ctx.state);
-        op_state.tracker.track_sync(ctx.id);
-        match deno_core::serde_v8::to_v8(scope, result) {
-            Ok(ret) => rv.set(ret),
-            Err(err) => {
-                deno_core::_ops::throw_type_error(
-                    scope,
-                    format!(
-                        "Error serializing return: {}",
-                        deno_core::anyhow::Error::from(err)
-                    ),
-                )
-            }
-        };
-    }
-}
-struct op_string_length_fast {
-    _phantom: ::std::marker::PhantomData<()>,
-}
-impl<'scope> deno_core::v8::fast_api::FastFunction for op_string_length_fast {
-    fn function(&self) -> *const ::std::ffi::c_void {
-        op_string_length_fast_fn as *const ::std::ffi::c_void
-    }
-    fn args(&self) -> &'static [deno_core::v8::fast_api::Type] {
-        use deno_core::v8::fast_api::Type::*;
-        use deno_core::v8::fast_api::CType;
-        &[V8Value, SeqOneByteString]
-    }
-    fn return_type(&self) -> deno_core::v8::fast_api::CType {
-        deno_core::v8::fast_api::CType::Uint32
-    }
-}
-fn op_string_length_fast_fn<'scope>(
-    _: deno_core::v8::Local<deno_core::v8::Object>,
-    string: *const deno_core::v8::fast_api::FastApiOneByteString,
-) -> u32 {
-    use deno_core::v8;
-    use deno_core::_ops;
-    let string = unsafe { &*string }.as_str().to_owned();
-    let result = op_string_length::call(string);
-    result
-}
diff --git a/ops/optimizer_tests/owned_string.rs b/ops/optimizer_tests/owned_string.rs
deleted file mode 100644
index 102cf00fb..000000000
--- a/ops/optimizer_tests/owned_string.rs
+++ /dev/null
@@ -1,3 +0,0 @@
-fn op_string_length(string: String) -> u32 {
-  string.len() as u32
-}
diff --git a/ops/optimizer_tests/strings.expected b/ops/optimizer_tests/strings.expected
deleted file mode 100644
index ead741054..000000000
--- a/ops/optimizer_tests/strings.expected
+++ /dev/null
@@ -1,11 +0,0 @@
-=== Optimizer Dump ===
-returns_result: false
-has_ref_opstate: false
-has_rc_opstate: false
-has_fast_callback_option: false
-needs_fast_callback_option: false
-fast_result: Some(U32)
-fast_parameters: [V8Value, SeqOneByteString]
-transforms: {0: Transform { kind: SeqOneByteString(Ref), index: 0 }}
-is_async: false
-fast_compatible: true
diff --git a/ops/optimizer_tests/strings.out b/ops/optimizer_tests/strings.out
deleted file mode 100644
index 41f09c4f8..000000000
--- a/ops/optimizer_tests/strings.out
+++ /dev/null
@@ -1,100 +0,0 @@
-#[allow(non_camel_case_types)]
-///Auto-generated by `deno_ops`, i.e: `#[op]`
-///
-///Use `op_string_length::decl()` to get an op-declaration
-///you can include in a `deno_core::Extension`.
-pub struct op_string_length;
-#[doc(hidden)]
-impl op_string_length {
-    pub fn name() -> &'static str {
-        stringify!(op_string_length)
-    }
-    pub fn v8_fn_ptr<'scope>() -> deno_core::v8::FunctionCallback {
-        use deno_core::v8::MapFnTo;
-        Self::v8_func.map_fn_to()
-    }
-    pub fn decl<'scope>() -> deno_core::OpDecl {
-        deno_core::OpDecl {
-            name: Self::name(),
-            v8_fn_ptr: Self::v8_fn_ptr(),
-            enabled: true,
-            fast_fn: Some(
-                Box::new(op_string_length_fast {
-                    _phantom: ::std::marker::PhantomData,
-                }),
-            ),
-            is_async: false,
-            is_unstable: false,
-            is_v8: false,
-            argc: 1usize,
-        }
-    }
-    #[inline]
-    #[allow(clippy::too_many_arguments)]
-    fn call(string: &str) -> u32 {
-        string.len() as u32
-    }
-    pub fn v8_func<'scope>(
-        scope: &mut deno_core::v8::HandleScope<'scope>,
-        args: deno_core::v8::FunctionCallbackArguments,
-        mut rv: deno_core::v8::ReturnValue,
-    ) {
-        let ctx = unsafe {
-            &*(deno_core::v8::Local::<deno_core::v8::External>::cast(args.data()).value()
-                as *const deno_core::_ops::OpCtx)
-        };
-        let arg_0 = match deno_core::v8::Local::<
-            deno_core::v8::String,
-        >::try_from(args.get(0usize as i32)) {
-            Ok(v8_string) => deno_core::serde_v8::to_utf8(v8_string, scope),
-            Err(_) => {
-                return deno_core::_ops::throw_type_error(
-                    scope,
-                    format!("Expected string at position {}", 0usize),
-                );
-            }
-        };
-        let arg_0 = arg_0.as_ref();
-        let result = Self::call(arg_0);
-        let op_state = ::std::cell::RefCell::borrow(&*ctx.state);
-        op_state.tracker.track_sync(ctx.id);
-        match deno_core::serde_v8::to_v8(scope, result) {
-            Ok(ret) => rv.set(ret),
-            Err(err) => {
-                deno_core::_ops::throw_type_error(
-                    scope,
-                    format!(
-                        "Error serializing return: {}",
-                        deno_core::anyhow::Error::from(err)
-                    ),
-                )
-            }
-        };
-    }
-}
-struct op_string_length_fast {
-    _phantom: ::std::marker::PhantomData<()>,
-}
-impl<'scope> deno_core::v8::fast_api::FastFunction for op_string_length_fast {
-    fn function(&self) -> *const ::std::ffi::c_void {
-        op_string_length_fast_fn as *const ::std::ffi::c_void
-    }
-    fn args(&self) -> &'static [deno_core::v8::fast_api::Type] {
-        use deno_core::v8::fast_api::Type::*;
-        use deno_core::v8::fast_api::CType;
-        &[V8Value, SeqOneByteString]
-    }
-    fn return_type(&self) -> deno_core::v8::fast_api::CType {
-        deno_core::v8::fast_api::CType::Uint32
-    }
-}
-fn op_string_length_fast_fn<'scope>(
-    _: deno_core::v8::Local<deno_core::v8::Object>,
-    string: *const deno_core::v8::fast_api::FastApiOneByteString,
-) -> u32 {
-    use deno_core::v8;
-    use deno_core::_ops;
-    let string = unsafe { &*string }.as_str();
-    let result = op_string_length::call(string);
-    result
-}
diff --git a/ops/optimizer_tests/strings.rs b/ops/optimizer_tests/strings.rs
deleted file mode 100644
index 860f1e8ec..000000000
--- a/ops/optimizer_tests/strings.rs
+++ /dev/null
@@ -1,3 +0,0 @@
-fn op_string_length(string: &str) -> u32 {
-  string.len() as u32
-}