diff options
author | Kangwook Lee (이강욱) <pbzweihander@gmail.com> | 2023-06-26 06:41:48 +0900 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-06-25 21:41:48 +0000 |
commit | d8293cd8bc88eef54f95e2ad11441d2b8f4b6061 (patch) | |
tree | b6681e8a7069c56ac914e0de3355e98db995de11 /ops/optimizer_tests | |
parent | 8fe9b8a4cc381f9b94ce2caf10c61ddff864bdb4 (diff) |
fix(ops): quoting serde_v8::Value (#19593)
The following code:
```rust
use deno_core::op;
#[op]
fn ops_serde_v8(value: serde_v8::Value) {
//
}
fn main() {
//
}
```
...with the following `Cargo.toml`:
```toml
[package]
name = "playground"
version = "0.1.0"
edition = "2021"
[dependencies]
deno_core = "0.191.0"
serde_v8 = "0.102.0"
```
...will not compile with the error:
```
error[E0433]: failed to resolve: use of undeclared crate or module `v8`
--> src/main.rs:3:1
|
3 | #[op]
| ^^^^^ use of undeclared crate or module `v8`
|
= note: this error originates in the attribute macro `op` (in Nightly builds, run with -Z macro-backtrace for more info)
```
This PR is fixing the above issue by properly quoting
`deno_core::v8::Value` instead of `v8::Value`.
Diffstat (limited to 'ops/optimizer_tests')
-rw-r--r-- | ops/optimizer_tests/serde_v8_value.out | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ops/optimizer_tests/serde_v8_value.out b/ops/optimizer_tests/serde_v8_value.out index 1a3d1ed31..034caec50 100644 --- a/ops/optimizer_tests/serde_v8_value.out +++ b/ops/optimizer_tests/serde_v8_value.out @@ -88,7 +88,7 @@ impl op_is_proxy { #[allow(clippy::too_many_arguments)] fn op_is_proxy_fast_fn<'scope>( _: deno_core::v8::Local<deno_core::v8::Object>, - value: deno_core::v8::Local<v8::Value>, + value: deno_core::v8::Local<deno_core::v8::Value>, ) -> bool { use deno_core::v8; use deno_core::_ops; |