diff options
| author | Matt Mastracci <matthew@mastracci.com> | 2023-06-25 16:36:09 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-25 16:36:09 +0200 |
| commit | 8fe9b8a4cc381f9b94ce2caf10c61ddff864bdb4 (patch) | |
| tree | 9ae0797ef865f0f0a023052f7dbe433d238561d4 /ops/op2/generator_state.rs | |
| parent | 3fe44a50c37b3f045c95a2085b58cfe3f71e8f6a (diff) | |
refactor(ops): ops2 supports result in fast path (#19603)
Implements `Result` in fast-calls. Note that the approach here is
slightly different. Rather than store the last result in the `OpState`,
we put it into the `OpCtx` which saves us a lookup and lock in the error
case. We do not have to lock this field as it's guaranteed only one
runtime and thread can ever access it.
The fastcall path for many ops can avoid doing a great deal of work,
even for `Result` return values. In the previous iteration of `ops`, all
`Result`-returning functions would fetch and lock the `OpState`,
regardless of whether it was used or not.
Diffstat (limited to 'ops/op2/generator_state.rs')
| -rw-r--r-- | ops/op2/generator_state.rs | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/ops/op2/generator_state.rs b/ops/op2/generator_state.rs index 16249c217..e437ea47c 100644 --- a/ops/op2/generator_state.rs +++ b/ops/op2/generator_state.rs @@ -21,6 +21,8 @@ pub struct GeneratorState { pub fn_args: Ident, /// The `OpCtx` used for various information required for some ops. pub opctx: Ident, + /// The `FastApiCallbackOptions` used in fast calls for fallback returns. + pub fast_api_callback_options: Ident, /// The `v8::ReturnValue` used in the slow function pub retval: Ident, /// The "slow" function (ie: the one that isn't a fastcall) @@ -33,4 +35,6 @@ pub struct GeneratorState { pub needs_scope: bool, pub needs_opstate: bool, pub needs_opctx: bool, + pub needs_fast_opctx: bool, + pub needs_fast_api_callback_options: bool, } |