diff options
| author | Ryan Dahl <ry@tinyclouds.org> | 2018-12-17 20:05:18 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-12-17 20:05:18 -0500 |
| commit | 1e54f1d47362308d7eabb02b3ddaa1f670e4ca08 (patch) | |
| tree | b1cd4e27295b9b82cdaaa37779c60be9c7faea44 /libdeno/libdeno_test.cc | |
| parent | 04076465cf2bda0af35fa255a56516aa6f9732ad (diff) | |
Remove from test_cc SnapshotterInitializesCorrectly (#1361)
Unfortunately V8 has a debug-only assert that checks
that a SnapshotCreator actually created a snapshot:
https://github.com/denoland/deno_third_party/blob/7d8c9aa769778140e1619f545e706bf34545509e/v8/src/api.cc#L571
This was not being triggered in Linux & Mac debug builds
because we were using the prebuilt release V8 build.
It was being triggered in Windows debug build because there is
a prebuilt v8_debug.lib. However the Windows error went unnoticed
because we only run release builds in CI.
Diffstat (limited to 'libdeno/libdeno_test.cc')
| -rw-r--r-- | libdeno/libdeno_test.cc | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/libdeno/libdeno_test.cc b/libdeno/libdeno_test.cc index 9627f4a8d..a992f5303 100644 --- a/libdeno/libdeno_test.cc +++ b/libdeno/libdeno_test.cc @@ -14,11 +14,6 @@ TEST(LibDenoTest, InitializesCorrectlyWithoutSnapshot) { deno_delete(d); } -TEST(LibDenoTest, SnapshotterInitializesCorrectly) { - Deno* d = deno_new(deno_config{1, empty, empty, nullptr}); - deno_delete(d); -} - TEST(LibDenoTest, Snapshotter) { Deno* d1 = deno_new(deno_config{1, empty, empty, nullptr}); EXPECT_TRUE(deno_execute(d1, nullptr, "a.js", "a = 1 + 2")); |