diff options
| author | Ryan Dahl <ry@tinyclouds.org> | 2018-12-17 20:05:18 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-12-17 20:05:18 -0500 |
| commit | 1e54f1d47362308d7eabb02b3ddaa1f670e4ca08 (patch) | |
| tree | b1cd4e27295b9b82cdaaa37779c60be9c7faea44 /libdeno/deno.h | |
| parent | 04076465cf2bda0af35fa255a56516aa6f9732ad (diff) | |
Remove from test_cc SnapshotterInitializesCorrectly (#1361)
Unfortunately V8 has a debug-only assert that checks
that a SnapshotCreator actually created a snapshot:
https://github.com/denoland/deno_third_party/blob/7d8c9aa769778140e1619f545e706bf34545509e/v8/src/api.cc#L571
This was not being triggered in Linux & Mac debug builds
because we were using the prebuilt release V8 build.
It was being triggered in Windows debug build because there is
a prebuilt v8_debug.lib. However the Windows error went unnoticed
because we only run release builds in CI.
Diffstat (limited to 'libdeno/deno.h')
| -rw-r--r-- | libdeno/deno.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/libdeno/deno.h b/libdeno/deno.h index e0ba63153..324f09a95 100644 --- a/libdeno/deno.h +++ b/libdeno/deno.h @@ -36,6 +36,9 @@ typedef struct { deno_recv_cb recv_cb; // Maps to libdeno.send() calls. } deno_config; +// Create a new deno isolate. +// Warning: If config.will_snapshot is set, deno_get_snapshot() must be called +// or an error will result. Deno* deno_new(deno_config config); // Generate a snapshot. The resulting buf can be used with deno_new. |