summaryrefslogtreecommitdiff
path: root/libdeno/api.cc
diff options
context:
space:
mode:
authorRyan Dahl <ry@tinyclouds.org>2019-02-01 19:46:54 -0500
committerRyan Dahl <ry@tinyclouds.org>2019-02-02 16:46:31 -0500
commit1770a77bca32a852892292406407ae52a0e29992 (patch)
tree2bcb94c50957e822b3200749f3a2396533c84efd /libdeno/api.cc
parent0b082c4361c63768e5b8610cb22ad7c79e9214aa (diff)
Clean up return value of deno_execute
and deno_respond
Diffstat (limited to 'libdeno/api.cc')
-rw-r--r--libdeno/api.cc15
1 files changed, 6 insertions, 9 deletions
diff --git a/libdeno/api.cc b/libdeno/api.cc
index af3c4b215..2c72b1265 100644
--- a/libdeno/api.cc
+++ b/libdeno/api.cc
@@ -112,8 +112,8 @@ const char* deno_last_exception(Deno* d_) {
}
}
-int deno_execute(Deno* d_, void* user_data, const char* js_filename,
- const char* js_source) {
+void deno_execute(Deno* d_, void* user_data, const char* js_filename,
+ const char* js_source) {
auto* d = unwrap(d_);
deno::UserDataScope user_data_scope(d, user_data);
auto* isolate = d->isolate_;
@@ -122,17 +122,17 @@ int deno_execute(Deno* d_, void* user_data, const char* js_filename,
v8::HandleScope handle_scope(isolate);
auto context = d->context_.Get(d->isolate_);
CHECK(!context.IsEmpty());
- return deno::Execute(context, js_filename, js_source) ? 1 : 0;
+ deno::Execute(context, js_filename, js_source);
}
-int deno_respond(Deno* d_, void* user_data, int32_t req_id, deno_buf buf) {
+void deno_respond(Deno* d_, void* user_data, int32_t req_id, deno_buf buf) {
auto* d = unwrap(d_);
if (d->current_args_ != nullptr) {
// Synchronous response.
auto ab = deno::ImportBuf(d, buf);
d->current_args_->GetReturnValue().Set(ab);
d->current_args_ = nullptr;
- return 0;
+ return;
}
// Asynchronous response.
@@ -151,7 +151,7 @@ int deno_respond(Deno* d_, void* user_data, int32_t req_id, deno_buf buf) {
auto recv_ = d->recv_.Get(d->isolate_);
if (recv_.IsEmpty()) {
d->last_exception_ = "libdeno.recv_ has not been called.";
- return 1;
+ return;
}
v8::Local<v8::Value> args[1];
@@ -161,10 +161,7 @@ int deno_respond(Deno* d_, void* user_data, int32_t req_id, deno_buf buf) {
if (try_catch.HasCaught()) {
CHECK(v.IsEmpty());
deno::HandleException(context, try_catch.Exception());
- return 1;
}
-
- return 0;
}
void deno_check_promise_errors(Deno* d_) {