diff options
author | Kitson Kelly <me@kitsonkelly.com> | 2019-02-13 02:08:56 +1100 |
---|---|---|
committer | Ryan Dahl <ry@tinyclouds.org> | 2019-02-12 10:08:56 -0500 |
commit | a21a5ad2fa4dcbad58fe63c298c69f8607705bf4 (patch) | |
tree | 03e0092f46813ffdf84f53ab58f71b8a0276207e /js/make_temp_dir_test.ts | |
parent | 1e5e091cb074896c7550b1b6f802582f12629048 (diff) |
Add Deno global namespace (#1748)
Resolves #1705
This PR adds the Deno APIs as a global namespace named `Deno`. For backwards
compatibility, the ability to `import * from "deno"` is preserved. I have tried
to convert every test and internal code the references the module to use the
namespace instead, but because I didn't break compatibility I am not sure.
On the REPL, `deno` no longer exists, replaced only with `Deno` to align with
the regular runtime.
The runtime type library includes both the namespace and module. This means it
duplicates the whole type information. When we remove the functionality from the
runtime, it will be a one line change to the library generator to remove the
module definition from the type library.
I marked a `TODO` in a couple places where to remove the `"deno"` module, but
there are additional places I know I didn't mark.
Diffstat (limited to 'js/make_temp_dir_test.ts')
-rw-r--r-- | js/make_temp_dir_test.ts | 25 |
1 files changed, 12 insertions, 13 deletions
diff --git a/js/make_temp_dir_test.ts b/js/make_temp_dir_test.ts index 84b10ae52..2b593402f 100644 --- a/js/make_temp_dir_test.ts +++ b/js/make_temp_dir_test.ts @@ -1,10 +1,9 @@ // Copyright 2018-2019 the Deno authors. All rights reserved. MIT license. import { test, testPerm, assert, assertEqual } from "./test_util.ts"; -import * as deno from "deno"; testPerm({ write: true }, function makeTempDirSyncSuccess() { - const dir1 = deno.makeTempDirSync({ prefix: "hello", suffix: "world" }); - const dir2 = deno.makeTempDirSync({ prefix: "hello", suffix: "world" }); + const dir1 = Deno.makeTempDirSync({ prefix: "hello", suffix: "world" }); + const dir2 = Deno.makeTempDirSync({ prefix: "hello", suffix: "world" }); // Check that both dirs are different. assert(dir1 !== dir2); for (const dir of [dir1, dir2]) { @@ -14,17 +13,17 @@ testPerm({ write: true }, function makeTempDirSyncSuccess() { assert(lastPart.endsWith("world")); } // Check that the `dir` option works. - const dir3 = deno.makeTempDirSync({ dir: dir1 }); + const dir3 = Deno.makeTempDirSync({ dir: dir1 }); assert(dir3.startsWith(dir1)); assert(/^[\\\/]/.test(dir3.slice(dir1.length))); // Check that creating a temp dir inside a nonexisting directory fails. let err; try { - deno.makeTempDirSync({ dir: "/baddir" }); + Deno.makeTempDirSync({ dir: "/baddir" }); } catch (err_) { err = err_; } - assertEqual(err.kind, deno.ErrorKind.NotFound); + assertEqual(err.kind, Deno.ErrorKind.NotFound); assertEqual(err.name, "NotFound"); }); @@ -32,17 +31,17 @@ test(function makeTempDirSyncPerm() { // makeTempDirSync should require write permissions (for now). let err; try { - deno.makeTempDirSync({ dir: "/baddir" }); + Deno.makeTempDirSync({ dir: "/baddir" }); } catch (err_) { err = err_; } - assertEqual(err.kind, deno.ErrorKind.PermissionDenied); + assertEqual(err.kind, Deno.ErrorKind.PermissionDenied); assertEqual(err.name, "PermissionDenied"); }); testPerm({ write: true }, async function makeTempDirSuccess() { - const dir1 = await deno.makeTempDir({ prefix: "hello", suffix: "world" }); - const dir2 = await deno.makeTempDir({ prefix: "hello", suffix: "world" }); + const dir1 = await Deno.makeTempDir({ prefix: "hello", suffix: "world" }); + const dir2 = await Deno.makeTempDir({ prefix: "hello", suffix: "world" }); // Check that both dirs are different. assert(dir1 !== dir2); for (const dir of [dir1, dir2]) { @@ -52,16 +51,16 @@ testPerm({ write: true }, async function makeTempDirSuccess() { assert(lastPart.endsWith("world")); } // Check that the `dir` option works. - const dir3 = await deno.makeTempDir({ dir: dir1 }); + const dir3 = await Deno.makeTempDir({ dir: dir1 }); assert(dir3.startsWith(dir1)); assert(/^[\\\/]/.test(dir3.slice(dir1.length))); // Check that creating a temp dir inside a nonexisting directory fails. let err; try { - await deno.makeTempDir({ dir: "/baddir" }); + await Deno.makeTempDir({ dir: "/baddir" }); } catch (err_) { err = err_; } - assertEqual(err.kind, deno.ErrorKind.NotFound); + assertEqual(err.kind, Deno.ErrorKind.NotFound); assertEqual(err.name, "NotFound"); }); |