diff options
| author | Aaron O'Mullan <aaron.omullan@gmail.com> | 2022-05-15 13:27:56 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-15 13:27:56 +0200 |
| commit | f5c31b56e3fb57a92dbaaec17690bfa9d787164e (patch) | |
| tree | 4b9cd72ed81d16430734240e2a57bcf1739334fe /ext | |
| parent | b08b1da6f4550601eec23327bd40d17ad6a6b4e9 (diff) | |
Revert "core: don't include_str extension js code (#10786)" (#14614)
This reverts commit 10e50a120744de71d6915af4ae93f8231607573d
Alternative to #13217, IMO the tradeoffs made by #10786 aren't worth it.
It breaks abstractions (crates being self-contained, deno_core without snapshotting etc...) and causes pain points / gotchas for both embedders & devs for a relatively minimal gain in incremental build time ...
Closes #11030
Diffstat (limited to 'ext')
| -rw-r--r-- | ext/url/benches/url_ops.rs | 4 | ||||
| -rw-r--r-- | ext/web/benches/timers_ops.rs | 10 | ||||
| -rw-r--r-- | ext/webgpu/src/01_webgpu.js (renamed from ext/webgpu/01_webgpu.js) | 0 | ||||
| -rw-r--r-- | ext/webgpu/src/02_idl_types.js (renamed from ext/webgpu/02_idl_types.js) | 0 |
4 files changed, 5 insertions, 9 deletions
diff --git a/ext/url/benches/url_ops.rs b/ext/url/benches/url_ops.rs index ed27b6f80..315ea7260 100644 --- a/ext/url/benches/url_ops.rs +++ b/ext/url/benches/url_ops.rs @@ -11,9 +11,7 @@ fn setup() -> Vec<Extension> { Extension::builder() .js(vec![( "setup", - Box::new(|| { - Ok(r#"const { URL } = globalThis.__bootstrap.url;"#.to_owned()) - }), + "const { URL } = globalThis.__bootstrap.url;", )]) .build(), ] diff --git a/ext/web/benches/timers_ops.rs b/ext/web/benches/timers_ops.rs index 30f50b7d9..f5d03d6c3 100644 --- a/ext/web/benches/timers_ops.rs +++ b/ext/web/benches/timers_ops.rs @@ -26,12 +26,10 @@ fn setup() -> Vec<Extension> { deno_web::init::<Permissions>(BlobStore::default(), None), Extension::builder() .js(vec![ - ("setup", - Box::new(|| Ok(r#" - const { opNow, setTimeout, handleTimerMacrotask } = globalThis.__bootstrap.timers; - Deno.core.setMacrotaskCallback(handleTimerMacrotask); - "#.to_owned())), - ), + ("setup", r#" + const { opNow, setTimeout, handleTimerMacrotask } = globalThis.__bootstrap.timers; + Deno.core.setMacrotaskCallback(handleTimerMacrotask); + "#), ]) .state(|state| { state.put(Permissions{}); diff --git a/ext/webgpu/01_webgpu.js b/ext/webgpu/src/01_webgpu.js index be880d81d..be880d81d 100644 --- a/ext/webgpu/01_webgpu.js +++ b/ext/webgpu/src/01_webgpu.js diff --git a/ext/webgpu/02_idl_types.js b/ext/webgpu/src/02_idl_types.js index 0dd8c00f9..0dd8c00f9 100644 --- a/ext/webgpu/02_idl_types.js +++ b/ext/webgpu/src/02_idl_types.js |