diff options
author | Divy Srivastava <dj.srivastava23@gmail.com> | 2022-12-01 21:29:15 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-12-02 05:29:15 +0000 |
commit | 9b2b8df927ac23cfa99016a684179f2a3198ba2e (patch) | |
tree | 1d13b575bc7c4f7279b2ff3fdde175a7522d643a /ext/webstorage/lib.rs | |
parent | 075854e5162c3d9f4fd7061d19acbe2c5855536e (diff) |
feat(ops): Fast zero copy string arguments (#16777)
Uses SeqOneByteString optimization to do zero-copy `&str` arguments in
fast calls.
- [x] Depends on https://github.com/denoland/rusty_v8/pull/1129
- [x] Depends on
https://chromium-review.googlesource.com/c/v8/v8/+/4036884
- [x] Disable in async ops
- [x] Make it work with owned `String` with an extra alloc in fast path.
- [x] Support `Cow<'_, str>`. Owned for slow case, Borrowed for fast
case
```rust
#[op]
fn op_string_len(s: &str) -> u32 {
str.len() as u32
}
```
Diffstat (limited to 'ext/webstorage/lib.rs')
-rw-r--r-- | ext/webstorage/lib.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ext/webstorage/lib.rs b/ext/webstorage/lib.rs index 6284a59bc..58b7c07e4 100644 --- a/ext/webstorage/lib.rs +++ b/ext/webstorage/lib.rs @@ -139,8 +139,8 @@ pub fn op_webstorage_key( #[op] pub fn op_webstorage_set( state: &mut OpState, - key: String, - value: String, + key: &str, + value: &str, persistent: bool, ) -> Result<(), AnyError> { let conn = get_webstorage(state, persistent)?; @@ -184,7 +184,7 @@ pub fn op_webstorage_get( #[op] pub fn op_webstorage_remove( state: &mut OpState, - key_name: String, + key_name: &str, persistent: bool, ) -> Result<(), AnyError> { let conn = get_webstorage(state, persistent)?; |