Revert "perf(ext/node): improve `Buffer` from string performance" (#24851)

1 files changed, 4 insertions, 35 deletions

diff --git a/ext/web/lib.rs b/ext/web/lib.rs
index c8badbf8a..89f1197e7 100644
--- a/ext/web/lib.rs
+++ b/ext/web/lib.rs
@@ -16,6 +16,7 @@ use deno_core::ByteString;
 use deno_core::OpState;
 use deno_core::Resource;
 use deno_core::ResourceId;
+use deno_core::ToJsBuffer;
 use deno_core::U16String;
 
 use encoding_rs::CoderResult;
@@ -61,7 +62,6 @@ deno_core::extension!(deno_web,
   parameters = [P: TimersPermission],
   ops = [
     op_base64_decode,
-    op_base64_write,
     op_base64_encode,
     op_base64_atob,
     op_base64_btoa,
@@ -130,43 +130,12 @@ deno_core::extension!(deno_web,
 );
 
 #[op2]
-#[buffer]
-fn op_base64_decode(#[string] input: String) -> Result<Vec<u8>, AnyError> {
+#[serde]
+fn op_base64_decode(#[string] input: String) -> Result<ToJsBuffer, AnyError> {
   let mut s = input.into_bytes();
   let decoded_len = forgiving_base64_decode_inplace(&mut s)?;
   s.truncate(decoded_len);
-  Ok(s)
-}
-
-#[op2(fast)]
-#[smi]
-fn op_base64_write(
-  #[string] input: String,
-  #[buffer] buffer: &mut [u8],
-  #[smi] start: u32,
-  #[smi] max_len: u32,
-) -> Result<u32, AnyError> {
-  let tsb_len = buffer.len() as u32;
-
-  if start > tsb_len {
-    return Err(type_error("Offset is out of bounds"));
-  }
-
-  let max_len = std::cmp::min(max_len, tsb_len - start) as usize;
-  let start = start as usize;
-
-  if max_len == 0 {
-    return Ok(0);
-  }
-
-  let mut s = input.into_bytes();
-  let decoded_len = forgiving_base64_decode_inplace(&mut s)?;
-
-  let max_len = std::cmp::min(max_len, decoded_len);
-
-  buffer[start..start + max_len].copy_from_slice(&s[..max_len]);
-
-  Ok(max_len as u32)
+  Ok(s.into())
 }
 
 #[op2]