fix(ext/web): Prevent (De-)CompressionStream resource leak on stream cancellation (#21199)

Based on #21074 and #20741 I was looking for further potential use cases
of `TransformStream` `cancel()` method, so here go `CompressionStream`
and `DecompressionStream`.

Fixes #14212

1 files changed, 18 insertions, 8 deletions

diff --git a/ext/web/compression.rs b/ext/web/compression.rs
index 0829af8e5..4f4d90cbf 100644
--- a/ext/web/compression.rs
+++ b/ext/web/compression.rs
@@ -116,25 +116,35 @@ pub fn op_compression_write(
 pub fn op_compression_finish(
   state: &mut OpState,
   #[smi] rid: ResourceId,
+  report_errors: bool,
 ) -> Result<ToJsBuffer, AnyError> {
   let resource = state.resource_table.take::<CompressionResource>(rid)?;
   let resource = Rc::try_unwrap(resource).unwrap();
   let inner = resource.0.into_inner();
-  let out: Vec<u8> = match inner {
+  let out = match inner {
     Inner::DeflateDecoder(d) => {
-      d.finish().map_err(|e| type_error(e.to_string()))?
+      d.finish().map_err(|e| type_error(e.to_string()))
     }
     Inner::DeflateEncoder(d) => {
-      d.finish().map_err(|e| type_error(e.to_string()))?
+      d.finish().map_err(|e| type_error(e.to_string()))
     }
     Inner::DeflateRawDecoder(d) => {
-      d.finish().map_err(|e| type_error(e.to_string()))?
+      d.finish().map_err(|e| type_error(e.to_string()))
     }
     Inner::DeflateRawEncoder(d) => {
-      d.finish().map_err(|e| type_error(e.to_string()))?
+      d.finish().map_err(|e| type_error(e.to_string()))
     }
-    Inner::GzDecoder(d) => d.finish().map_err(|e| type_error(e.to_string()))?,
-    Inner::GzEncoder(d) => d.finish().map_err(|e| type_error(e.to_string()))?,
+    Inner::GzDecoder(d) => d.finish().map_err(|e| type_error(e.to_string())),
+    Inner::GzEncoder(d) => d.finish().map_err(|e| type_error(e.to_string())),
   };
-  Ok(out.into())
+  match out {
+    Err(err) => {
+      if report_errors {
+        Err(err)
+      } else {
+        Ok(Vec::with_capacity(0).into())
+      }
+    }
+    Ok(out) => Ok(out.into()),
+  }
 }