diff options
author | Divy Srivastava <dj.srivastava23@gmail.com> | 2022-12-01 21:29:15 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-12-02 05:29:15 +0000 |
commit | 9b2b8df927ac23cfa99016a684179f2a3198ba2e (patch) | |
tree | 1d13b575bc7c4f7279b2ff3fdde175a7522d643a /ext/url/lib.rs | |
parent | 075854e5162c3d9f4fd7061d19acbe2c5855536e (diff) |
feat(ops): Fast zero copy string arguments (#16777)
Uses SeqOneByteString optimization to do zero-copy `&str` arguments in
fast calls.
- [x] Depends on https://github.com/denoland/rusty_v8/pull/1129
- [x] Depends on
https://chromium-review.googlesource.com/c/v8/v8/+/4036884
- [x] Disable in async ops
- [x] Make it work with owned `String` with an extra alloc in fast path.
- [x] Support `Cow<'_, str>`. Owned for slow case, Borrowed for fast
case
```rust
#[op]
fn op_string_len(s: &str) -> u32 {
str.len() as u32
}
```
Diffstat (limited to 'ext/url/lib.rs')
-rw-r--r-- | ext/url/lib.rs | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/ext/url/lib.rs b/ext/url/lib.rs index ac668207f..01014ccd3 100644 --- a/ext/url/lib.rs +++ b/ext/url/lib.rs @@ -41,11 +41,11 @@ pub fn init() -> Extension { #[op] pub fn op_url_parse_with_base( state: &mut OpState, - href: String, - base_href: String, - buf: &mut [u8], + href: &str, + base_href: &str, + buf: &mut [u32], ) -> u32 { - let base_url = match Url::parse(&base_href) { + let base_url = match Url::parse(base_href) { Ok(url) => url, Err(_) => return ParseStatus::Err as u32, }; @@ -67,8 +67,8 @@ pub fn op_url_get_serialization(state: &mut OpState) -> String { } /// Parse `href` without a `base_url`. Fills the out `buf` with URL components. -#[op] -pub fn op_url_parse(state: &mut OpState, href: String, buf: &mut [u8]) -> u32 { +#[op(fast)] +pub fn op_url_parse(state: &mut OpState, href: &str, buf: &mut [u32]) -> u32 { parse_url(state, href, None, buf) } @@ -99,15 +99,14 @@ pub fn op_url_parse(state: &mut OpState, href: String, buf: &mut [u8]) -> u32 { #[inline] fn parse_url( state: &mut OpState, - href: String, + href: &str, base_href: Option<&Url>, - buf: &mut [u8], + buf: &mut [u32], ) -> u32 { - match Url::options().base_url(base_href).parse(&href) { + match Url::options().base_url(base_href).parse(href) { Ok(url) => { let inner_url = quirks::internal_components(&url); - let buf: &mut [u32] = as_u32_slice(buf); buf[0] = inner_url.scheme_end; buf[1] = inner_url.username_end; buf[2] = inner_url.host_start; |