diff options
author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2024-04-16 00:06:39 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-04-16 01:06:39 +0200 |
commit | 0b8d7d1d4b068df46a14895b2f55c00781bd1eef (patch) | |
tree | 0a478c09731a8f5c15b3eaee5124dadd39631edc /ext/node/polyfills/worker_threads.ts | |
parent | 46c709e52f712ef7e1e41285ec06e9bbbe10c0a5 (diff) |
fix(ext/node): panic on 'worker_threads.receiveMessageOnPort' (#23386)
Closes https://github.com/denoland/deno/issues/23362
Previously we were panicking if there was a pending read on a
port and `receiveMessageOnPort` was called. This is now fixed
by cancelling the pending read, trying to read a message and
resuming reading in a loop.
Diffstat (limited to 'ext/node/polyfills/worker_threads.ts')
-rw-r--r-- | ext/node/polyfills/worker_threads.ts | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/ext/node/polyfills/worker_threads.ts b/ext/node/polyfills/worker_threads.ts index 323095206..f61e7e3e3 100644 --- a/ext/node/polyfills/worker_threads.ts +++ b/ext/node/polyfills/worker_threads.ts @@ -17,6 +17,7 @@ import { MessagePort, MessagePortIdSymbol, MessagePortPrototype, + MessagePortReceiveMessageOnPortSymbol, nodeWorkerThreadCloseCb, refMessagePort, serializeJsMessageData, @@ -441,6 +442,7 @@ export function receiveMessageOnPort(port: MessagePort): object | undefined { err["code"] = "ERR_INVALID_ARG_TYPE"; throw err; } + port[MessagePortReceiveMessageOnPortSymbol] = true; const data = op_message_port_recv_message_sync(port[MessagePortIdSymbol]); if (data === null) return undefined; return { message: deserializeJsMessageData(data)[0] }; |