diff options
author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2023-03-04 22:31:38 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-03-05 02:31:38 +0000 |
commit | b40086fd7da3729d1d59b312c89ee57747fc66a9 (patch) | |
tree | 991583010635feab13fae77e7c8a35fef0a09095 /ext/node/polyfills/url.ts | |
parent | 01028fcdf4f379a7285cc15079306e3ac31edcc1 (diff) |
refactor(core): include_js_files! 'dir' option doesn't change specifiers (#18019)
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.
Example:
```
include_js_files! {
dir "js",
"hello.js",
}
```
The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.
The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".
Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
Diffstat (limited to 'ext/node/polyfills/url.ts')
-rw-r--r-- | ext/node/polyfills/url.ts | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/ext/node/polyfills/url.ts b/ext/node/polyfills/url.ts index 6d38fd1ff..4366f14ea 100644 --- a/ext/node/polyfills/url.ts +++ b/ext/node/polyfills/url.ts @@ -27,8 +27,8 @@ import { ERR_INVALID_FILE_URL_PATH, ERR_INVALID_URL, ERR_INVALID_URL_SCHEME, -} from "internal:deno_node/polyfills/internal/errors.ts"; -import { validateString } from "internal:deno_node/polyfills/internal/validators.mjs"; +} from "internal:deno_node/internal/errors.ts"; +import { validateString } from "internal:deno_node/internal/validators.mjs"; import { CHAR_0, CHAR_9, @@ -65,19 +65,19 @@ import { CHAR_UPPERCASE_Z, CHAR_VERTICAL_LINE, CHAR_ZERO_WIDTH_NOBREAK_SPACE, -} from "internal:deno_node/polyfills/path/_constants.ts"; -import * as path from "internal:deno_node/polyfills/path.ts"; -import { toASCII, toUnicode } from "internal:deno_node/polyfills/punycode.ts"; -import { isWindows, osType } from "internal:deno_node/polyfills/_util/os.ts"; +} from "internal:deno_node/path/_constants.ts"; +import * as path from "internal:deno_node/path.ts"; +import { toASCII, toUnicode } from "internal:deno_node/punycode.ts"; +import { isWindows, osType } from "internal:deno_node/_util/os.ts"; import { encodeStr, hexTable, -} from "internal:deno_node/polyfills/internal/querystring.ts"; -import querystring from "internal:deno_node/polyfills/querystring.ts"; +} from "internal:deno_node/internal/querystring.ts"; +import querystring from "internal:deno_node/querystring.ts"; import type { ParsedUrlQuery, ParsedUrlQueryInput, -} from "internal:deno_node/polyfills/querystring.ts"; +} from "internal:deno_node/querystring.ts"; import { URL, URLSearchParams } from "internal:deno_url/00_url.js"; const forwardSlashRegEx = /\//g; |