diff options
author | Marvin Hagemeister <marvin@deno.com> | 2024-05-20 15:24:13 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-05-20 15:24:13 +0200 |
commit | fb3f82b9eafef7da732c0af7e8a86c3b87075e3c (patch) | |
tree | cffcb5edd9e5c8b3c7128a685ab26c5cf30af371 /ext/node/polyfills/process.ts | |
parent | d7709daaa09ebd40b5756a2ce6d3e1c0c3bf7984 (diff) |
fix(node): track `SIG*` listeners in `process.listeners` (#23890)
Some npm libraries like `signal-exit` rely on the length of the listener
array returned by `process.listeners("SIGNT")` to be correct to
function. We weren't tracking `SIG*` events there, which broke those npm
libraries.
Fixes https://github.com/denoland/deno/issues/22892
Diffstat (limited to 'ext/node/polyfills/process.ts')
-rw-r--r-- | ext/node/polyfills/process.ts | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/ext/node/polyfills/process.ts b/ext/node/polyfills/process.ts index 9c73f5a51..f742e6634 100644 --- a/ext/node/polyfills/process.ts +++ b/ext/node/polyfills/process.ts @@ -469,6 +469,7 @@ Process.prototype.on = function ( } else if (event === "SIGTERM" && Deno.build.os === "windows") { // Ignores SIGTERM on windows. } else { + EventEmitter.prototype.on.call(this, event, listener); Deno.addSignalListener(event as Deno.Signal, listener); } } else { @@ -494,6 +495,7 @@ Process.prototype.off = function ( } else if (event === "SIGTERM" && Deno.build.os === "windows") { // Ignores SIGTERM on windows. } else { + EventEmitter.prototype.off.call(this, event, listener); Deno.removeSignalListener(event as Deno.Signal, listener); } } else { @@ -537,6 +539,7 @@ Process.prototype.prependListener = function ( if (event === "SIGBREAK" && Deno.build.os !== "windows") { // Ignores SIGBREAK if the platform is not windows. } else { + EventEmitter.prototype.prependListener.call(this, event, listener); Deno.addSignalListener(event as Deno.Signal, listener); } } else { |