refactor: rename InternalModuleLoader to ExtModuleLoader, use ext: scheme for snapshotted modules (#18041)

This commit renames "deno_core::InternalModuleLoader" to
"ExtModuleLoader" and changes the specifiers used by the 
modules loaded from this loader to "ext:".

"internal:" scheme was really ambiguous and it's more characters than
"ext:", which should result in slightly smaller snapshot size.

Closes https://github.com/denoland/deno/issues/18020

17 files changed, 76 insertions, 76 deletions

diff --git a/ext/node/polyfills/internal_binding/_timingSafeEqual.ts b/ext/node/polyfills/internal_binding/_timingSafeEqual.ts
index a1cc093d6..8ac64d2ea 100644
--- a/ext/node/polyfills/internal_binding/_timingSafeEqual.ts
+++ b/ext/node/polyfills/internal_binding/_timingSafeEqual.ts
@@ -1,5 +1,5 @@
 // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
-import { Buffer } from "internal:deno_node/buffer.ts";
+import { Buffer } from "ext:deno_node/buffer.ts";
 
 function assert(cond) {
   if (!cond) {
diff --git a/ext/node/polyfills/internal_binding/_utils.ts b/ext/node/polyfills/internal_binding/_utils.ts
index 4d545df0e..d21f46ef1 100644
--- a/ext/node/polyfills/internal_binding/_utils.ts
+++ b/ext/node/polyfills/internal_binding/_utils.ts
@@ -2,7 +2,7 @@
 import {
   forgivingBase64Decode,
   forgivingBase64UrlEncode,
-} from "internal:deno_web/00_infra.js";
+} from "ext:deno_web/00_infra.js";
 
 export function asciiToBytes(str: string) {
   const byteArray = [];
diff --git a/ext/node/polyfills/internal_binding/buffer.ts b/ext/node/polyfills/internal_binding/buffer.ts
index 5d0af81ca..3796b5da0 100644
--- a/ext/node/polyfills/internal_binding/buffer.ts
+++ b/ext/node/polyfills/internal_binding/buffer.ts
@@ -1,5 +1,5 @@
 // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
-import { Encodings } from "internal:deno_node/internal_binding/_node.ts";
+import { Encodings } from "ext:deno_node/internal_binding/_node.ts";
 
 export function indexOfNeedle(
   source: Uint8Array,
diff --git a/ext/node/polyfills/internal_binding/cares_wrap.ts b/ext/node/polyfills/internal_binding/cares_wrap.ts
index b09af3728..0a7345a3d 100644
--- a/ext/node/polyfills/internal_binding/cares_wrap.ts
+++ b/ext/node/polyfills/internal_binding/cares_wrap.ts
@@ -24,17 +24,17 @@
 // - https://github.com/nodejs/node/blob/master/src/cares_wrap.cc
 // - https://github.com/nodejs/node/blob/master/src/cares_wrap.h
 
-import type { ErrnoException } from "internal:deno_node/internal/errors.ts";
-import { isIPv4 } from "internal:deno_node/internal/net.ts";
-import { codeMap } from "internal:deno_node/internal_binding/uv.ts";
+import type { ErrnoException } from "ext:deno_node/internal/errors.ts";
+import { isIPv4 } from "ext:deno_node/internal/net.ts";
+import { codeMap } from "ext:deno_node/internal_binding/uv.ts";
 import {
   AsyncWrap,
   providerType,
-} from "internal:deno_node/internal_binding/async_wrap.ts";
+} from "ext:deno_node/internal_binding/async_wrap.ts";
 // deno-lint-ignore camelcase
-import { ares_strerror } from "internal:deno_node/internal_binding/ares.ts";
-import { notImplemented } from "internal:deno_node/_utils.ts";
-import { isWindows } from "internal:deno_node/_util/os.ts";
+import { ares_strerror } from "ext:deno_node/internal_binding/ares.ts";
+import { notImplemented } from "ext:deno_node/_utils.ts";
+import { isWindows } from "ext:deno_node/_util/os.ts";
 
 interface LookupAddress {
   address: string;
diff --git a/ext/node/polyfills/internal_binding/connection_wrap.ts b/ext/node/polyfills/internal_binding/connection_wrap.ts
index d4d85d99a..493d3c102 100644
--- a/ext/node/polyfills/internal_binding/connection_wrap.ts
+++ b/ext/node/polyfills/internal_binding/connection_wrap.ts
@@ -24,11 +24,11 @@
 // - https://github.com/nodejs/node/blob/master/src/connection_wrap.cc
 // - https://github.com/nodejs/node/blob/master/src/connection_wrap.h
 
-import { LibuvStreamWrap } from "internal:deno_node/internal_binding/stream_wrap.ts";
+import { LibuvStreamWrap } from "ext:deno_node/internal_binding/stream_wrap.ts";
 import {
   AsyncWrap,
   providerType,
-} from "internal:deno_node/internal_binding/async_wrap.ts";
+} from "ext:deno_node/internal_binding/async_wrap.ts";
 
 interface Reader {
   read(p: Uint8Array): Promise<number | null>;
diff --git a/ext/node/polyfills/internal_binding/crypto.ts b/ext/node/polyfills/internal_binding/crypto.ts
index 97b6990c9..3e310bb98 100644
--- a/ext/node/polyfills/internal_binding/crypto.ts
+++ b/ext/node/polyfills/internal_binding/crypto.ts
@@ -1,9 +1,9 @@
 // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
 // Copyright Joyent, Inc. and Node.js contributors. All rights reserved. MIT license.
 
-import { notImplemented } from "internal:deno_node/_utils.ts";
+import { notImplemented } from "ext:deno_node/_utils.ts";
 
-export { timingSafeEqual } from "internal:deno_node/internal_binding/_timingSafeEqual.ts";
+export { timingSafeEqual } from "ext:deno_node/internal_binding/_timingSafeEqual.ts";
 
 export function getFipsCrypto(): boolean {
   notImplemented("crypto.getFipsCrypto");
diff --git a/ext/node/polyfills/internal_binding/handle_wrap.ts b/ext/node/polyfills/internal_binding/handle_wrap.ts
index 9b037e302..9ba495edb 100644
--- a/ext/node/polyfills/internal_binding/handle_wrap.ts
+++ b/ext/node/polyfills/internal_binding/handle_wrap.ts
@@ -24,11 +24,11 @@
 // - https://github.com/nodejs/node/blob/master/src/handle_wrap.cc
 // - https://github.com/nodejs/node/blob/master/src/handle_wrap.h
 
-import { unreachable } from "internal:deno_node/_util/asserts.ts";
+import { unreachable } from "ext:deno_node/_util/asserts.ts";
 import {
   AsyncWrap,
   providerType,
-} from "internal:deno_node/internal_binding/async_wrap.ts";
+} from "ext:deno_node/internal_binding/async_wrap.ts";
 
 export class HandleWrap extends AsyncWrap {
   constructor(provider: providerType) {
diff --git a/ext/node/polyfills/internal_binding/mod.ts b/ext/node/polyfills/internal_binding/mod.ts
index e7fde9cbc..466840098 100644
--- a/ext/node/polyfills/internal_binding/mod.ts
+++ b/ext/node/polyfills/internal_binding/mod.ts
@@ -1,18 +1,18 @@
 // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
-import * as asyncWrap from "internal:deno_node/internal_binding/async_wrap.ts";
-import * as buffer from "internal:deno_node/internal_binding/buffer.ts";
-import * as caresWrap from "internal:deno_node/internal_binding/cares_wrap.ts";
-import * as constants from "internal:deno_node/internal_binding/constants.ts";
-import * as crypto from "internal:deno_node/internal_binding/crypto.ts";
-import * as pipeWrap from "internal:deno_node/internal_binding/pipe_wrap.ts";
-import * as streamWrap from "internal:deno_node/internal_binding/stream_wrap.ts";
-import * as stringDecoder from "internal:deno_node/internal_binding/string_decoder.ts";
-import * as symbols from "internal:deno_node/internal_binding/symbols.ts";
-import * as tcpWrap from "internal:deno_node/internal_binding/tcp_wrap.ts";
-import * as types from "internal:deno_node/internal_binding/types.ts";
-import * as udpWrap from "internal:deno_node/internal_binding/udp_wrap.ts";
-import * as util from "internal:deno_node/internal_binding/util.ts";
-import * as uv from "internal:deno_node/internal_binding/uv.ts";
+import * as asyncWrap from "ext:deno_node/internal_binding/async_wrap.ts";
+import * as buffer from "ext:deno_node/internal_binding/buffer.ts";
+import * as caresWrap from "ext:deno_node/internal_binding/cares_wrap.ts";
+import * as constants from "ext:deno_node/internal_binding/constants.ts";
+import * as crypto from "ext:deno_node/internal_binding/crypto.ts";
+import * as pipeWrap from "ext:deno_node/internal_binding/pipe_wrap.ts";
+import * as streamWrap from "ext:deno_node/internal_binding/stream_wrap.ts";
+import * as stringDecoder from "ext:deno_node/internal_binding/string_decoder.ts";
+import * as symbols from "ext:deno_node/internal_binding/symbols.ts";
+import * as tcpWrap from "ext:deno_node/internal_binding/tcp_wrap.ts";
+import * as types from "ext:deno_node/internal_binding/types.ts";
+import * as udpWrap from "ext:deno_node/internal_binding/udp_wrap.ts";
+import * as util from "ext:deno_node/internal_binding/util.ts";
+import * as uv from "ext:deno_node/internal_binding/uv.ts";
 
 const modules = {
   "async_wrap": asyncWrap,
diff --git a/ext/node/polyfills/internal_binding/node_file.ts b/ext/node/polyfills/internal_binding/node_file.ts
index 1c45f91ff..82ff55b75 100644
--- a/ext/node/polyfills/internal_binding/node_file.ts
+++ b/ext/node/polyfills/internal_binding/node_file.ts
@@ -25,7 +25,7 @@
 // - https://github.com/nodejs/node/blob/master/src/node_file.cc
 // - https://github.com/nodejs/node/blob/master/src/node_file.h
 
-import { assert } from "internal:deno_node/_util/asserts.ts";
+import { assert } from "ext:deno_node/_util/asserts.ts";
 
 /**
  * Write to the given file from the given buffer synchronously.
diff --git a/ext/node/polyfills/internal_binding/pipe_wrap.ts b/ext/node/polyfills/internal_binding/pipe_wrap.ts
index 9a1571dd3..aa1248781 100644
--- a/ext/node/polyfills/internal_binding/pipe_wrap.ts
+++ b/ext/node/polyfills/internal_binding/pipe_wrap.ts
@@ -24,24 +24,24 @@
 // - https://github.com/nodejs/node/blob/master/src/pipe_wrap.cc
 // - https://github.com/nodejs/node/blob/master/src/pipe_wrap.h
 
-import { notImplemented } from "internal:deno_node/_utils.ts";
-import { unreachable } from "internal:deno_node/_util/asserts.ts";
-import { ConnectionWrap } from "internal:deno_node/internal_binding/connection_wrap.ts";
+import { notImplemented } from "ext:deno_node/_utils.ts";
+import { unreachable } from "ext:deno_node/_util/asserts.ts";
+import { ConnectionWrap } from "ext:deno_node/internal_binding/connection_wrap.ts";
 import {
   AsyncWrap,
   providerType,
-} from "internal:deno_node/internal_binding/async_wrap.ts";
-import { LibuvStreamWrap } from "internal:deno_node/internal_binding/stream_wrap.ts";
-import { codeMap } from "internal:deno_node/internal_binding/uv.ts";
-import { delay } from "internal:deno_node/_util/async.ts";
-import { kStreamBaseField } from "internal:deno_node/internal_binding/stream_wrap.ts";
+} from "ext:deno_node/internal_binding/async_wrap.ts";
+import { LibuvStreamWrap } from "ext:deno_node/internal_binding/stream_wrap.ts";
+import { codeMap } from "ext:deno_node/internal_binding/uv.ts";
+import { delay } from "ext:deno_node/_util/async.ts";
+import { kStreamBaseField } from "ext:deno_node/internal_binding/stream_wrap.ts";
 import {
   ceilPowOf2,
   INITIAL_ACCEPT_BACKOFF_DELAY,
   MAX_ACCEPT_BACKOFF_DELAY,
-} from "internal:deno_node/internal_binding/_listen.ts";
-import { isWindows } from "internal:deno_node/_util/os.ts";
-import { fs } from "internal:deno_node/internal_binding/constants.ts";
+} from "ext:deno_node/internal_binding/_listen.ts";
+import { isWindows } from "ext:deno_node/_util/os.ts";
+import { fs } from "ext:deno_node/internal_binding/constants.ts";
 
 export enum socketType {
   SOCKET,
diff --git a/ext/node/polyfills/internal_binding/stream_wrap.ts b/ext/node/polyfills/internal_binding/stream_wrap.ts
index 1f7d9f6c5..40c72bb8f 100644
--- a/ext/node/polyfills/internal_binding/stream_wrap.ts
+++ b/ext/node/polyfills/internal_binding/stream_wrap.ts
@@ -27,15 +27,15 @@
 // - https://github.com/nodejs/node/blob/master/src/stream_wrap.h
 // - https://github.com/nodejs/node/blob/master/src/stream_wrap.cc
 
-import { TextEncoder } from "internal:deno_web/08_text_encoding.js";
-import { Buffer } from "internal:deno_node/buffer.ts";
-import { notImplemented } from "internal:deno_node/_utils.ts";
-import { HandleWrap } from "internal:deno_node/internal_binding/handle_wrap.ts";
+import { TextEncoder } from "ext:deno_web/08_text_encoding.js";
+import { Buffer } from "ext:deno_node/buffer.ts";
+import { notImplemented } from "ext:deno_node/_utils.ts";
+import { HandleWrap } from "ext:deno_node/internal_binding/handle_wrap.ts";
 import {
   AsyncWrap,
   providerType,
-} from "internal:deno_node/internal_binding/async_wrap.ts";
-import { codeMap } from "internal:deno_node/internal_binding/uv.ts";
+} from "ext:deno_node/internal_binding/async_wrap.ts";
+import { codeMap } from "ext:deno_node/internal_binding/uv.ts";
 
 interface Reader {
   read(p: Uint8Array): Promise<number | null>;
diff --git a/ext/node/polyfills/internal_binding/string_decoder.ts b/ext/node/polyfills/internal_binding/string_decoder.ts
index f1307f562..59f982d91 100644
--- a/ext/node/polyfills/internal_binding/string_decoder.ts
+++ b/ext/node/polyfills/internal_binding/string_decoder.ts
@@ -1,5 +1,5 @@
 // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
-import { Encodings } from "internal:deno_node/internal_binding/_node.ts";
+import { Encodings } from "ext:deno_node/internal_binding/_node.ts";
 
 const encodings = [];
 encodings[Encodings.ASCII] = "ascii";
diff --git a/ext/node/polyfills/internal_binding/tcp_wrap.ts b/ext/node/polyfills/internal_binding/tcp_wrap.ts
index 029e39048..6f571c72c 100644
--- a/ext/node/polyfills/internal_binding/tcp_wrap.ts
+++ b/ext/node/polyfills/internal_binding/tcp_wrap.ts
@@ -24,24 +24,24 @@
 // - https://github.com/nodejs/node/blob/master/src/tcp_wrap.cc
 // - https://github.com/nodejs/node/blob/master/src/tcp_wrap.h
 
-import { notImplemented } from "internal:deno_node/_utils.ts";
-import { unreachable } from "internal:deno_node/_util/asserts.ts";
-import { ConnectionWrap } from "internal:deno_node/internal_binding/connection_wrap.ts";
+import { notImplemented } from "ext:deno_node/_utils.ts";
+import { unreachable } from "ext:deno_node/_util/asserts.ts";
+import { ConnectionWrap } from "ext:deno_node/internal_binding/connection_wrap.ts";
 import {
   AsyncWrap,
   providerType,
-} from "internal:deno_node/internal_binding/async_wrap.ts";
-import { LibuvStreamWrap } from "internal:deno_node/internal_binding/stream_wrap.ts";
-import { ownerSymbol } from "internal:deno_node/internal_binding/symbols.ts";
-import { codeMap } from "internal:deno_node/internal_binding/uv.ts";
-import { delay } from "internal:deno_node/_util/async.ts";
-import { kStreamBaseField } from "internal:deno_node/internal_binding/stream_wrap.ts";
-import { isIP } from "internal:deno_node/internal/net.ts";
+} from "ext:deno_node/internal_binding/async_wrap.ts";
+import { LibuvStreamWrap } from "ext:deno_node/internal_binding/stream_wrap.ts";
+import { ownerSymbol } from "ext:deno_node/internal_binding/symbols.ts";
+import { codeMap } from "ext:deno_node/internal_binding/uv.ts";
+import { delay } from "ext:deno_node/_util/async.ts";
+import { kStreamBaseField } from "ext:deno_node/internal_binding/stream_wrap.ts";
+import { isIP } from "ext:deno_node/internal/net.ts";
 import {
   ceilPowOf2,
   INITIAL_ACCEPT_BACKOFF_DELAY,
   MAX_ACCEPT_BACKOFF_DELAY,
-} from "internal:deno_node/internal_binding/_listen.ts";
+} from "ext:deno_node/internal_binding/_listen.ts";
 
 /** The type of TCP socket. */
 enum socketType {
diff --git a/ext/node/polyfills/internal_binding/types.ts b/ext/node/polyfills/internal_binding/types.ts
index f79f4132e..943f5e31d 100644
--- a/ext/node/polyfills/internal_binding/types.ts
+++ b/ext/node/polyfills/internal_binding/types.ts
@@ -21,7 +21,7 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-import { core } from "internal:deno_node/_core.ts";
+import { core } from "ext:deno_node/_core.ts";
 
 // https://tc39.es/ecma262/#sec-object.prototype.tostring
 const _toString = Object.prototype.toString;
diff --git a/ext/node/polyfills/internal_binding/udp_wrap.ts b/ext/node/polyfills/internal_binding/udp_wrap.ts
index eb499eb50..b36334a54 100644
--- a/ext/node/polyfills/internal_binding/udp_wrap.ts
+++ b/ext/node/polyfills/internal_binding/udp_wrap.ts
@@ -23,17 +23,17 @@
 import {
   AsyncWrap,
   providerType,
-} from "internal:deno_node/internal_binding/async_wrap.ts";
-import { GetAddrInfoReqWrap } from "internal:deno_node/internal_binding/cares_wrap.ts";
-import { HandleWrap } from "internal:deno_node/internal_binding/handle_wrap.ts";
-import { ownerSymbol } from "internal:deno_node/internal_binding/symbols.ts";
-import { codeMap, errorMap } from "internal:deno_node/internal_binding/uv.ts";
-import { notImplemented } from "internal:deno_node/_utils.ts";
-import { Buffer } from "internal:deno_node/buffer.ts";
-import type { ErrnoException } from "internal:deno_node/internal/errors.ts";
-import { isIP } from "internal:deno_node/internal/net.ts";
-
-import { isLinux, isWindows } from "internal:deno_node/_util/os.ts";
+} from "ext:deno_node/internal_binding/async_wrap.ts";
+import { GetAddrInfoReqWrap } from "ext:deno_node/internal_binding/cares_wrap.ts";
+import { HandleWrap } from "ext:deno_node/internal_binding/handle_wrap.ts";
+import { ownerSymbol } from "ext:deno_node/internal_binding/symbols.ts";
+import { codeMap, errorMap } from "ext:deno_node/internal_binding/uv.ts";
+import { notImplemented } from "ext:deno_node/_utils.ts";
+import { Buffer } from "ext:deno_node/buffer.ts";
+import type { ErrnoException } from "ext:deno_node/internal/errors.ts";
+import { isIP } from "ext:deno_node/internal/net.ts";
+
+import { isLinux, isWindows } from "ext:deno_node/_util/os.ts";
 
 // @ts-ignore Deno[Deno.internal] is used on purpose here
 const DenoListenDatagram = Deno[Deno.internal]?.nodeUnstable?.listenDatagram ||
diff --git a/ext/node/polyfills/internal_binding/util.ts b/ext/node/polyfills/internal_binding/util.ts
index 79084c694..f2d23d4f3 100644
--- a/ext/node/polyfills/internal_binding/util.ts
+++ b/ext/node/polyfills/internal_binding/util.ts
@@ -25,7 +25,7 @@
 // - https://github.com/nodejs/node/blob/master/src/util.cc
 // - https://github.com/nodejs/node/blob/master/src/util.h
 
-import { notImplemented } from "internal:deno_node/_utils.ts";
+import { notImplemented } from "ext:deno_node/_utils.ts";
 
 export function guessHandleType(_fd: number): string {
   notImplemented("util.guessHandleType");
diff --git a/ext/node/polyfills/internal_binding/uv.ts b/ext/node/polyfills/internal_binding/uv.ts
index b760560bf..e7f6b890b 100644
--- a/ext/node/polyfills/internal_binding/uv.ts
+++ b/ext/node/polyfills/internal_binding/uv.ts
@@ -26,9 +26,9 @@
 //
 // See also: http://docs.libuv.org/en/v1.x/errors.html#error-constants
 
-import { unreachable } from "internal:deno_node/_util/asserts.ts";
-import { osType } from "internal:deno_node/_util/os.ts";
-import { uvTranslateSysError } from "internal:deno_node/internal_binding/_libuv_winerror.ts";
+import { unreachable } from "ext:deno_node/_util/asserts.ts";
+import { osType } from "ext:deno_node/_util/os.ts";
+import { uvTranslateSysError } from "ext:deno_node/internal_binding/_libuv_winerror.ts";
 
 // In Node these values are coming from libuv:
 // Ref: https://github.com/libuv/libuv/blob/v1.x/include/uv/errno.h