diff options
| author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2023-03-04 22:31:38 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-05 02:31:38 +0000 |
| commit | b40086fd7da3729d1d59b312c89ee57747fc66a9 (patch) | |
| tree | 991583010635feab13fae77e7c8a35fef0a09095 /ext/node/polyfills/internal_binding/cares_wrap.ts | |
| parent | 01028fcdf4f379a7285cc15079306e3ac31edcc1 (diff) | |
refactor(core): include_js_files! 'dir' option doesn't change specifiers (#18019)
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.
Example:
```
include_js_files! {
dir "js",
"hello.js",
}
```
The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.
The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".
Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
Diffstat (limited to 'ext/node/polyfills/internal_binding/cares_wrap.ts')
| -rw-r--r-- | ext/node/polyfills/internal_binding/cares_wrap.ts | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/ext/node/polyfills/internal_binding/cares_wrap.ts b/ext/node/polyfills/internal_binding/cares_wrap.ts index 1345e9463..b09af3728 100644 --- a/ext/node/polyfills/internal_binding/cares_wrap.ts +++ b/ext/node/polyfills/internal_binding/cares_wrap.ts @@ -24,17 +24,17 @@ // - https://github.com/nodejs/node/blob/master/src/cares_wrap.cc // - https://github.com/nodejs/node/blob/master/src/cares_wrap.h -import type { ErrnoException } from "internal:deno_node/polyfills/internal/errors.ts"; -import { isIPv4 } from "internal:deno_node/polyfills/internal/net.ts"; -import { codeMap } from "internal:deno_node/polyfills/internal_binding/uv.ts"; +import type { ErrnoException } from "internal:deno_node/internal/errors.ts"; +import { isIPv4 } from "internal:deno_node/internal/net.ts"; +import { codeMap } from "internal:deno_node/internal_binding/uv.ts"; import { AsyncWrap, providerType, -} from "internal:deno_node/polyfills/internal_binding/async_wrap.ts"; +} from "internal:deno_node/internal_binding/async_wrap.ts"; // deno-lint-ignore camelcase -import { ares_strerror } from "internal:deno_node/polyfills/internal_binding/ares.ts"; -import { notImplemented } from "internal:deno_node/polyfills/_utils.ts"; -import { isWindows } from "internal:deno_node/polyfills/_util/os.ts"; +import { ares_strerror } from "internal:deno_node/internal_binding/ares.ts"; +import { notImplemented } from "internal:deno_node/_utils.ts"; +import { isWindows } from "internal:deno_node/_util/os.ts"; interface LookupAddress { address: string; |
