diff options
author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2023-03-04 22:31:38 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-03-05 02:31:38 +0000 |
commit | b40086fd7da3729d1d59b312c89ee57747fc66a9 (patch) | |
tree | 991583010635feab13fae77e7c8a35fef0a09095 /ext/node/polyfills/internal/fs/streams.d.ts | |
parent | 01028fcdf4f379a7285cc15079306e3ac31edcc1 (diff) |
refactor(core): include_js_files! 'dir' option doesn't change specifiers (#18019)
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.
Example:
```
include_js_files! {
dir "js",
"hello.js",
}
```
The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.
The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".
Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
Diffstat (limited to 'ext/node/polyfills/internal/fs/streams.d.ts')
-rw-r--r-- | ext/node/polyfills/internal/fs/streams.d.ts | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/ext/node/polyfills/internal/fs/streams.d.ts b/ext/node/polyfills/internal/fs/streams.d.ts index 9e70c2431..f5ed3b694 100644 --- a/ext/node/polyfills/internal/fs/streams.d.ts +++ b/ext/node/polyfills/internal/fs/streams.d.ts @@ -2,14 +2,14 @@ // Copyright DefinitelyTyped contributors. All rights reserved. MIT license. // deno-lint-ignore-file no-explicit-any -import * as stream from "internal:deno_node/polyfills/_stream.d.ts"; -import * as promises from "internal:deno_node/polyfills/fs/promises.ts"; +import * as stream from "internal:deno_node/_stream.d.ts"; +import * as promises from "internal:deno_node/fs/promises.ts"; -import { Buffer } from "internal:deno_node/polyfills/buffer.ts"; +import { Buffer } from "internal:deno_node/buffer.ts"; import { BufferEncoding, ErrnoException, -} from "internal:deno_node/polyfills/_global.d.ts"; +} from "internal:deno_node/_global.d.ts"; type PathLike = string | Buffer | URL; @@ -253,7 +253,7 @@ interface ReadStreamOptions extends StreamOptions { * also required. * * ```js - * import { createReadStream } from "internal:deno_node/polyfills/internal/fs/fs"; + * import { createReadStream } from "internal:deno_node/internal/fs/fs"; * * // Create a stream from some character device. * const stream = createReadStream('/dev/input/event0'); @@ -281,7 +281,7 @@ interface ReadStreamOptions extends StreamOptions { * An example to read the last 10 bytes of a file which is 100 bytes long: * * ```js - * import { createReadStream } from "internal:deno_node/polyfills/internal/fs/fs"; + * import { createReadStream } from "internal:deno_node/internal/fs/fs"; * * createReadStream('sample.txt', { start: 90, end: 99 }); * ``` |